Bug 637264: Reset posting codeunits transaction state after Commit in cost adjustment#8944
Open
alexei-dobriansky wants to merge 3 commits into
Open
Bug 637264: Reset posting codeunits transaction state after Commit in cost adjustment#8944alexei-dobriansky wants to merge 3 commits into
alexei-dobriansky wants to merge 3 commits into
Conversation
… cost adjustment Adds ResetTransactionState / ResetGLPostingState plumbing so an explicit Commit() during item-by-item cost adjustment re-takes the G/L Entry table lock and re-reads the last entry number, preventing a duplicate-key race. Includes feature telemetry and parallel-run tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ayers + telemetry tag Propagates the ResetTransactionState / ResetGLPostingState fix from W1 to all country localizations (APAC, BE, CH, ES, FI, FR, IT, NA, NO, RU) via miapp. Also assigns telemetry event-ID tag 0000MEQ to the cost-adjustment item-by-item commit usage telemetry in W1, APAC and RU. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…637264-ResetPostingCUsStateAfterCommitInCostAdjmt
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#637264
Problem
During item-by-item cost adjustment, an explicit
Commit()releases the G/L Entry table lock whileNextEntryNois still cached, allowing a concurrent session to read the same last entry number and hit a duplicate-key error.Fix
Gen. Jnl.-Post Line: newResetTransactionStatethat clears the transaction-scoped caches so the next post re-takes the G/L Entry lock and re-reads the last entry number.Inventory Posting To G/L/Item Jnl.-Post Line:ResetGLPostingStateplumbing to forward the reset.Inventory Adjustment.CheckAndCommit: calls the reset after eachCommit()and emits feature telemetry (event ID0000MEQ).Localization
The W1 change is propagated to all affected country layers (APAC, BE, CH, ES, FI, FR, IT, NA, NO, RU) via miapp.