Skip to content

Document GDL and Miapp development workflows#8946

Queued
mazhelez wants to merge 5 commits into
mainfrom
mazhelez-iron-merchant
Queued

Document GDL and Miapp development workflows#8946
mazhelez wants to merge 5 commits into
mainfrom
mazhelez-iron-merchant

Conversation

@mazhelez

@mazhelez mazhelez commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Documents the local GDL (layers/views) and Miapp development workflows in LOCAL_DEV_ENV.md, ignores generated GDL views, and fixes a git helper used by the Miapp tooling.

Note: This PR intentionally does not change GDLDevelopment.psm1. Automatic configuration of the VSCode launch.json/settings.json during New-GDLView (i.e. without -skipSetupDevelopmentSettings) is currently broken and will be fixed in a follow-up. The docs reflect this by using -skipSetupDevelopmentSettings.

Changes

Documentation (LOCAL_DEV_ENV.md)

  • GDL development (layers and views): Explains the layer/view model and the workflow — composing a view with New-GDLView, syncing changes back with Sync-GDLView (incl. -SyncMovesAndDeletes), and cleaning up with Remove-GDLView / Remove-AllGDLViews. Includes the symbolic-link prerequisite (Developer Mode / Administrator) and a note that automatic dev-settings setup is temporarily broken.
  • Miapp (propagating changes across layers): Explains what Miapp (Micro Application Integration) does — propagating W1 base-layer changes to dependent country layers — and how to invoke it (Import-Module .\build\scripts\Miapp\MicroApp.psm1 then Invoke-Miapp), with common options and a link to the full Miapp README.

.gitignore

  • Ignore the generated GDL App Views (src/Views) so composed views are never committed.

Git helper fix (build/scripts/Miapp/MicroAppGitHelper.psm1)

Get-GitCurrentRemoteBranch relied on a try/catch that never fired: 2>&1 redirected git's stderr into stdout, so fatal: no upstream configured for branch was returned as a normal string instead of raising a terminating error. Now the function inspects $LASTEXITCODE, returning the upstream branch on success, nothing for the expected "no upstream" case, and re-throwing any unexpected error.

Testing

  • Get-GitCurrentRemoteBranch returns empty (no throw) on a branch without an upstream.

AB#612711

mazhelez added 4 commits July 1, 2026 00:19
SetupDevelopmentSettings referenced the removed internal helper Get-NavServerInstanceNameForPublishing, an obsolete INETROOT projects.json path, and called Configure-ALProject with parameters that no longer exist, so New-GDLView failed with 'Configure-ALProject is not recognized'. Import ALDev.psm1, resolve launch/project settings via Get-LaunchSettings/Get-ProjectSettings, read build/projects.json from the repo root, and add -ContainerName/-Authentication to New-GDLView.
@github-actions github-actions Bot added the Build: scripts & configs Build scripts and configuration files label Jun 30, 2026
Add a Miapp section to LOCAL_DEV_ENV.md explaining what it does and how to invoke it. Revert the GDLDevelopment.psm1 dev-settings changes; automatic VSCode settings setup stays broken and will be fixed later, so the GDL doc now uses -skipSetupDevelopmentSettings.
@mazhelez mazhelez marked this pull request as ready for review June 30, 2026 22:51
@mazhelez mazhelez requested review from a team June 30, 2026 22:51
@mazhelez mazhelez changed the title Document GDL development workflow and fix GDL view setup and git helper Document GDL and Miapp development workflows; fix git helper Jun 30, 2026
@mazhelez mazhelez changed the title Document GDL and Miapp development workflows; fix git helper Document GDL and Miapp development workflows Jun 30, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jun 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: no-knowledge

The PR changes only .gitignore, LOCAL_DEV_ENV.md, and a PowerShell module (build/scripts/Miapp/MicroAppGitHelper.psm1); no AL source objects are present in the diff, so no AL knowledge domain applies. al-upgrade-review and al-ui-review returned not-applicable per their own diff-content rules; the remaining four leaves found no AL files to evaluate (no-knowledge).

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

No findings were posted for this iteration.

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

@mazhelez mazhelez enabled auto-merge July 1, 2026 08:25
@mazhelez mazhelez added this pull request to the merge queue Jul 1, 2026
Any commits made after this event will not be merged.
@aholstrup1 aholstrup1 removed this pull request from the merge queue due to a manual request Jul 1, 2026
@aholstrup1 aholstrup1 added this pull request to the merge queue Jul 1, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build: scripts & configs Build scripts and configuration files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants