Skip to content

Fix send box should narrate aria-label#5805

Open
compulim wants to merge 5 commits intomicrosoft:mainfrom
compulim:fix-send-box-aria-label
Open

Fix send box should narrate aria-label#5805
compulim wants to merge 5 commits intomicrosoft:mainfrom
compulim:fix-send-box-aria-label

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Apr 14, 2026

Changelog Entry

Fixed

  • Fixed send box should narrate aria-label prop, by @compulim, in PR #5805

Description

This is fixing aria-label that was passed but never render into HTML element.

Specific Changes

  • Updated both <input> and <textarea> to forward the aria-label prop
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review April 14, 2026 21:26
Copilot AI review requested due to automatic review settings April 14, 2026 21:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Fixes an accessibility gap where the send box’s aria-label could be provided but not rendered onto the underlying <input> / <textarea> element.

Changes:

  • Forward aria-label to the underlying <input> (AccessibleInputText) and <textarea> (TextArea).
  • Add runtime prop validation schemas (valibot) for AccessibleInputText and TextArea.
  • Add HTML-based accessibility tests covering aria-label for single-line, multi-line, and Fluent scenarios.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/component/src/Utils/AccessibleInputText.tsx Adds aria-label forwarding and introduces runtime prop validation via valibot schema.
packages/component/src/TextArea/TextArea.tsx Adds aria-label forwarding and introduces runtime prop validation via valibot schema.
tests/html2/accessibility/sendBox/ariaLabel.html New test verifying aria-label is applied for single-line send box (INPUT).
tests/html2/accessibility/sendBox/ariaLabel.multilineTextBox.html New test verifying aria-label is applied for multiline send box (TEXTAREA).
tests/html2/accessibility/sendBox/ariaLabel.fluent.html New test verifying aria-label is applied in Fluent setup.
CHANGELOG.md Adds changelog entry for the aria-label fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/component/src/TextArea/TextArea.tsx
Comment thread packages/component/src/Utils/AccessibleInputText.tsx
Comment thread packages/component/src/Utils/AccessibleInputText.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants