M8: GitHub Enterprise Server support#295
Draft
michaeljolley wants to merge 1 commit into
Draft
Conversation
Make the GitHub host configurable end-to-end so the extension can target a GitHub Enterprise Server (GHES) instance in addition to github.com. - GitHubHostAddress: a single resolver for host-specific URLs. It normalizes a user-entered host (bare host assumes https, empty means github.com), detects github.com versus GHES, and produces the Octokit REST API base (https://api.github.com/ or https://HOST/api/v3/) and the GraphQL endpoint (https://api.github.com/graphql or https://HOST/api/graphql). - GitHubGraphQLClient now derives its endpoint through GitHubHostAddress, so REST and GraphQL host logic share one source of truth. - OAuth login is host-aware: OAuthRequest accepts an optional host and builds its Octokit client against the enterprise API base, and IDeveloperIdProvider.LoginNewDeveloperIdAsync(host) threads the chosen host through the sign-in flow. The parameterless path still defaults to github.com, and restored accounts already carry their own host. - Sign In form gains an optional 'GitHub Enterprise Server host' field; blank keeps github.com. SignInCommand.Invoke(host) passes it through. - ResW strings and tests: host parsing, github.com vs GHES API/GraphQL resolution, and the GraphQL client delegation. 221/221 tests pass. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final milestone of the RayCast parity roadmap. Stacked on top of #294 (M7).
What this adds
Make the GitHub host configurable end-to-end so the extension can target a GitHub Enterprise Server (GHES) instance in addition to github.com.
Tests
Notes