Skip to content

Revise README for DiskANN3 #1046

Open
harsha-simhadri wants to merge 9 commits into
mainfrom
harshasi/update_readme
Open

Revise README for DiskANN3 #1046
harsha-simhadri wants to merge 9 commits into
mainfrom
harshasi/update_readme

Conversation

@harsha-simhadri
Copy link
Copy Markdown
Contributor

Updated README to reflect changes in DiskANN3 and added details about the Provider API and getting started guide.

Updated README to reflect changes in DiskANN3 and added details about the Provider API and getting started guide.
Corrected formatting and improved clarity in the README.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the top-level README to describe DiskANN3 (Rust main branch) and its Provider API, plus a short “Getting Started” section pointing to benchmarking and provider integration entry points.

Changes:

  • Replaces the prior badge/paper-heavy intro with a DiskANN3 overview and feature list.
  • Adds Provider API context and a “Getting Started” section with links to benchmarks and the provider contract.
  • Moves badges and paper links into the “Legacy C++ Code” section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Updated the README to clarify the DiskANN3 library's purpose and usage, including changes to the description of the API and algorithmic features.
Updated project name and description in README.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.47%. Comparing base (3d3ed4c) to head (4c7cd95).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1046      +/-   ##
==========================================
- Coverage   90.60%   89.47%   -1.13%     
==========================================
  Files         461      461              
  Lines       85494    85494              
==========================================
- Hits        77462    76498     -964     
- Misses       8032     8996     +964     
Flag Coverage Δ
miri 89.47% <ø> (-1.13%) ⬇️
unittests 89.32% <ø> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harsha-simhadri harsha-simhadri changed the title Revise README for DiskANN3 updates Revise README for DiskANN3 May 10, 2026
@harsha-simhadri harsha-simhadri enabled auto-merge (squash) May 10, 2026 23:01
Comment thread README.md
Comment thread README.md
Comment thread README.md
Comment thread README.md
[![DiskANN Paper](https://img.shields.io/badge/Paper-Filtered--DiskANN-blue)](https://harsha-simhadri.org/pubs/Filtered-DiskANN23.pdf)
To use DiskANN3 in your system, you would implement the `DataProvider` trait for your store to describe how index terms such as vectors, adjacency lists should be store and retrieved. DiskANN3 provides vector update and query API to users and internally uses the implementation of `DataProvider` trait to serve these requests.

This repo offers the following Provider implementations as illustrative examples:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to future-proof these claims with dates or version tags of competitors?

Comment thread README.md
The provider for [Cosmos DB NoSQL Vector Search](https://learn.microsoft.com/en-us/azure/cosmos-db/vector-search) is not included here but documented in the [VLDB'25 paper](https://www.vldb.org/pvldb/vol18/p5166-upreti.pdf).

The library supports the following algorithmic features
- Real-time updates (using [IP-DiskANN](https://arxiv.org/abs/2502.13826)) that support stable recall under long update streams -- no merges, rebuilds, patches needed.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also support the FreshDiskANN version, right? IP-DiskANN is just the default.

Copy link
Copy Markdown
Contributor Author

@harsha-simhadri harsha-simhadri May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we support the whole tier merge architecturein main branch?

Comment thread README.md

The provider for [Cosmos DB NoSQL Vector Search](https://learn.microsoft.com/en-us/azure/cosmos-db/vector-search) is not included here but documented in the [VLDB'25 paper](https://www.vldb.org/pvldb/vol18/p5166-upreti.pdf).

The library supports the following algorithmic features
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should mention special types of search such as range, diverse?

Comment thread README.md
Comment thread README.md
- Real-time updates (using [IP-DiskANN](https://arxiv.org/abs/2502.13826)) that support stable recall under long update streams -- no merges, rebuilds, patches needed.
- A diverse set of distance functions and quantizers (PQ, MinMax, Scalar, Spherical) implemented for x86 and aarch64.
- Choice of memory tiers to allow operation at different price-performance points.
- Hooks to allow attribute filters (predicate) processsing along with vector search.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"processing"

Comment thread README.md
@@ -24,7 +32,18 @@ See [guidelines](CONTRIBUTING.md) for contributing to this project.

## Legacy C++ Code
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention that this is DiskANN2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants