CmdPal: Enable dock pinning and per-profile icons for Windows Terminal by niels9001 · Pull Request #46372 · microsoft/PowerToys

niels9001 · 2026-03-21T14:59:37Z

Summary of the Pull Request

Enables Windows Terminal profiles to be pinned to the Command Palette dock and shows per-profile icons instead of the generic Terminal app logo.

Dock Pinning

Root cause: LaunchProfileCommand.Id was never set (defaulted to string.Empty). The context menu factory checks !string.IsNullOrEmpty(itemId) before showing "Pin to Dock", so the option was silently hidden. Additionally, GetCommandItem() was not overridden, so pinned commands could not be resolved on load.

Fix:

Set stable Id on LaunchProfileCommand (format: terminal/{appUserModelId}/{profileName})
Rename constructor parameter id → appUserModelId to avoid ambiguity with the generated command Id
Override GetCommandItem(string id) in WindowsTerminalCommandsProvider to look up profile items by ID

Per-Profile Icons

Root cause: All profiles showed the same Terminal application logo. The per-profile icon field from Terminal settings.json was parsed into TerminalProfile.Icon but never used.

Fix:

Add InstallPath to TerminalPackage (from Package.InstalledPath)
Add ResolveProfileIcon() helper to TerminalHelper that resolves ms-appx:/// URIs to the Terminal package install directory (with scale variant probing), passes through file paths and glyphs, and falls back to the Terminal logo
Cache the resolved icon in a local variable to avoid duplicate filesystem IO per profile
Set resolved per-profile icon on both ListItem.Icon and LaunchProfileCommand

Robustness

Use Guid.TryParse instead of Guid.Parse when reading profile GUIDs from settings.json, so a malformed or empty GUID value does not throw and take down the entire profile list

PR Checklist

Detailed Description of the Pull Request / Additional comments

Files changed:

Commands/LaunchProfileCommand.cs — Assigns stable Id, renames id → appUserModelId throughout, adds static MakeId() helper
Helpers/TerminalHelper.cs — Adds ResolveProfileIcon(), TryResolveGuidIcon(), and ResolveAppxPath() helpers; hardens GUID parsing with Guid.TryParse
Helpers/TerminalQuery.cs — Passes p.InstalledPath to the TerminalPackage constructor
Pages/ProfilesListPage.cs — Resolves and caches icon path per profile; sets ListItem.Icon
TerminalPackage.cs — Adds InstallPath property
WindowsTerminalCommandsProvider.cs — Overrides GetCommandItem(string id) for dock-pinned command rehydration; removes unused using directive

Validation Steps Performed

Build clean with exit code 0
Dock pinning tested and working — "Pin to Dock" option appears and survives restart
Per-profile icons verified — each profile displays its own icon in both the list and the dock

Enable Windows Terminal profiles to be pinned to the Command Palette dock and show per-profile icons instead of the generic Terminal app logo. Dock pinning: - Set stable Id on LaunchProfileCommand (terminal/{appUserModelId}/{profileName}) - Override GetCommandItem() in WindowsTerminalCommandsProvider so the dock can resolve pinned commands on load Per-profile icons: - Add InstallPath to TerminalPackage for resolving ms-appx:/// URIs - Add ResolveProfileIcon() helper that maps ms-appx:/// paths to the Terminal package install directory with scale variant probing - Set resolved per-profile icon on ListItem and LaunchProfileCommand Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

cinnamon-msft · 2026-03-21T16:01:39Z

YAY

Copilot

Pull request overview

Enables Windows Terminal profile commands in CmdPal to support dock pinning (via stable command IDs and provider-side rehydration) and improves UX by showing per-profile icons rather than the generic Terminal app icon.

Changes:

Assigns stable IDs to LaunchProfileCommand and adds GetCommandItem(string id) to rehydrate pinned profile commands.
Adds InstallPath to TerminalPackage and uses it to resolve profile icons (including ms-appx:/// and GUID-based built-in profile icons).
Updates the profiles list to use resolved per-profile icons for both list items and launch commands.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/WindowsTerminalCommandsProvider.cs	Adds `GetCommandItem` implementation to resolve pinned profile commands by ID.
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/TerminalPackage.cs	Extends package model with `InstallPath` needed for icon resolution.
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Pages/ProfilesListPage.cs	Applies resolved per-profile icons to the rendered list items and commands.
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Helpers/TerminalQuery.cs	Populates `InstallPath` from the discovered Terminal package.
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Helpers/TerminalHelper.cs	Adds icon resolution logic and updates GUID parsing under nullable context.
src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Commands/LaunchProfileCommand.cs	Generates and assigns stable command IDs for profile launch commands.

…ges/ProfilesListPage.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…lpers/TerminalHelper.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ndowsTerminalCommandsProvider.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-03-24T19:41:04Z

@michaeljolley I've opened a new pull request, #46481, to work on those changes. Once the pull request is ready, I'll request review from you.

…ove ambiguity (#46481) ## Summary of the Pull Request `LaunchProfileCommand` had a constructor parameter `id` and backing field `_id` that held the Terminal `AppUserModelId` used for COM activation, which was ambiguous given the base class `Id` property (set to a generated command identifier via `MakeId`). Renames the parameter and field throughout to `appUserModelId`/`_appUserModelId`. ## PR Checklist - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments Addresses review feedback on #46372. Changes in `LaunchProfileCommand.cs`: - `_id` field → `_appUserModelId` - Constructor parameter `id` → `appUserModelId` - Private `Launch(string id, ...)` → `Launch(string appUserModelId, ...)` Before, both the activation ID and the command identity used `id`-derived names, making it easy to accidentally pass the wrong value. The `MakeId` static method already used `appUserModelId` as its parameter; this aligns the rest of the class with that convention. ```csharp // Before private readonly string _id; internal LaunchProfileCommand(string id, ...) { this._id = id; this.Id = MakeId(id, profile); } // After private readonly string _appUserModelId; internal LaunchProfileCommand(string appUserModelId, ...) { this._appUserModelId = appUserModelId; this.Id = MakeId(appUserModelId, profile); } ``` ## Validation Steps Performed - Code review: no issues flagged. - Caller site (`ProfilesListPage.cs`) already passes `profile.Terminal.AppUserModelId` — no functional change.  --- 💬 Send tasks to Copilot coding agent from [Slack](https://gh.io/cca-slack-docs) and [Teams](https://gh.io/cca-teams-docs) to turn conversations into code. Copilot posts an update in your thread when it's finished. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: michaeljolley <1228996+michaeljolley@users.noreply.github.com>

jiripolasek · 2026-03-25T16:10:30Z

    }

-    private void Launch(string id, string profile)
+    internal static string MakeId(string appUserModelId, string profileName) => $"terminal/{appUserModelId}/{profileName}";


Not sure how this would fit with the deep-links... I assume we'd like to end up with sth like: x-cmdpal://commands/providerId/commandId and question is if / should be a reserved char or not? In theory we can treat commandId as catch-all parameter

@jiripolasek what is your recommendation here?

niels9001 · 2026-04-02T17:12:28Z

@copilot What's causing the CI to fail? can you sync this branch up with main?

Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>

Copilot · 2026-04-02T17:18:22Z

@copilot What's causing the CI to fail? can you sync this branch up with main?

The CI failures were caused by the branch being out of sync with main. The build on March 24 failed because main had accumulated changes after this branch was opened. I've merged main into this branch (commit b2b18e2b) — no conflicts in the files we changed, so CI should pass now.

niels9001 · 2026-04-03T09:27:15Z

@copilot sync this branch with main

…inal-dock-pinning Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>

Copilot · 2026-04-03T09:28:59Z

@copilot sync this branch with main

Done — merged latest main (commit b884c26). The 4 new commits from main (Peek archive previewer, PowerOCR image methods, spell-check pin/revert) had no conflicts with our changes.

…inal-dock-pinning

zadjii-msft · 2026-04-21T01:34:52Z

+            var iconPath = TerminalHelper.ResolveProfileIcon(profile);
+
+            result.Add(new ListItem(new LaunchProfileCommand(profile.Terminal.AppUserModelId, profile.Name, iconPath, openNewTab, openQuake, _appSettingsManager))


weird that we're resolving the icon path to a string, then constructing two different IconInfors for that string (both here, and down in the LaunchProfileCommand). Pretty sure we don't need the one up here, and the listitem will just use the command's icon

niels9001 force-pushed the niels9001/cmdpal-terminal-dock-pinning branch from 59f6260 to c533c34 Compare March 21, 2026 15:04

jiripolasek added the Product-Command Palette Refers to the Command Palette utility label Mar 21, 2026

niels9001 requested review from Copilot, jiripolasek and zadjii-msft March 21, 2026 19:14

Copilot started reviewing on behalf of niels9001 March 21, 2026 19:14 View session

Copilot AI reviewed Mar 21, 2026

View reviewed changes

michaeljolley and others added 3 commits March 24, 2026 14:37

Update src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Pa…

2488285

…ges/ProfilesListPage.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/He…

27bb510

…lpers/TerminalHelper.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Wi…

3c40282

…ndowsTerminalCommandsProvider.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Mar 24, 2026

CmdPal: Rename id→appUserModelId in LaunchProfileCommand to remove ambiguity #46481

Merged

10 tasks

jiripolasek reviewed Mar 25, 2026

View reviewed changes

Copilot started work on behalf of niels9001 April 2, 2026 17:12 View session

Merge main into niels9001/cmdpal-terminal-dock-pinning

b2b18e2

Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>

Copilot finished work on behalf of niels9001 April 2, 2026 17:19

This comment has been minimized.

Sign in to view

Copilot started work on behalf of niels9001 April 3, 2026 09:27 View session

Merge remote-tracking branch 'origin/main' into niels9001/cmdpal-term…

b884c26

…inal-dock-pinning Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>

Copilot finished work on behalf of niels9001 April 3, 2026 09:30

niels9001 and others added 3 commits April 8, 2026 16:43

Merge branch 'main' into niels9001/cmdpal-terminal-dock-pinning

ca2e1cb

Merge branch 'main' into niels9001/cmdpal-terminal-dock-pinning

6dabe70

Merge remote-tracking branch 'origin/main' into niels9001/cmdpal-term…

a39dd5d

…inal-dock-pinning

fix the build you dumb clanker

c348a30

zadjii-msft reviewed Apr 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CmdPal: Enable dock pinning and per-profile icons for Windows Terminal#46372

CmdPal: Enable dock pinning and per-profile icons for Windows Terminal#46372
niels9001 wants to merge 11 commits intomainfrom
niels9001/cmdpal-terminal-dock-pinning

niels9001 commented Mar 21, 2026 •

edited by Copilot AI

Loading

Uh oh!

cinnamon-msft commented Mar 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 24, 2026

Uh oh!

jiripolasek Mar 25, 2026

Uh oh!

niels9001 Mar 27, 2026

Uh oh!

niels9001 commented Apr 2, 2026

Uh oh!

Copilot AI commented Apr 2, 2026

Uh oh!

This comment has been minimized.

niels9001 commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

zadjii-msft Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

		var iconPath = TerminalHelper.ResolveProfileIcon(profile);

		result.Add(new ListItem(new LaunchProfileCommand(profile.Terminal.AppUserModelId, profile.Name, iconPath, openNewTab, openQuake, _appSettingsManager))

Conversation

niels9001 commented Mar 21, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

Dock Pinning

Per-Profile Icons

Robustness

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

cinnamon-msft commented Mar 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 24, 2026

Uh oh!

jiripolasek Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

niels9001 Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

niels9001 commented Apr 2, 2026

Uh oh!

Copilot AI commented Apr 2, 2026

Uh oh!

This comment has been minimized.

niels9001 commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

zadjii-msft Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

niels9001 commented Mar 21, 2026 •

edited by Copilot AI

Loading