Conversation
….Lib - Create PowerDisplay.Models project with shared model types (ColorPresetItem, CustomVcpValueMapping, PowerDisplayProfile, PowerDisplayProfiles, ProfileMonitorSetting) and ProfileHelper/ProfileSerializationContext - Remove Settings.UI and Settings.UI.Library dependency on PowerDisplay.Lib - Clean up VcpNames: remove LocalizedCodeNameProvider, GetValueMappings, GetFormattedValueName with custom mapping overload (keep 4 methods) - Refactor ProfileService: delegate Load/Save to ProfileHelper, remove unused methods (ProfilesFileExists, GetProfilesFilePath), simplify IProfileService interface - Remove legacy CustomProfileName constant and cleanup code - Add CustomVcpValueMappingExtensions in Lib for rich display properties - Create MonitorStateSerializationContext for Lib-local state types Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Restores PowerDisplay across the PowerToys solution, including build, packaging, signing, and UI integration in Settings, OOBE, and Dashboard. Refactors PowerDisplay app to use CommunityToolkit.Mvvm for ViewModels, moves control logic from code-behind to ViewModels, and modernizes XAML for improved accessibility and theming. Updates group policy support, resource strings, and installer logic. Removes obsolete code and improves maintainability and user experience.
This comment has been minimized.
This comment has been minimized.
Changed icon column widths in control grids to fixed 20px for consistent spacing. Disabled text scaling for monitor numbers to ensure uniform appearance regardless of system text size settings.
This comment has been minimized.
This comment has been minimized.
Added "NOTOPMOST" after "nosize-notopmost" in expect.txt to update the list of recognized terms. No other modifications were made.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Move load→modify→save sequences into ProfileHelper so both Settings.UI and PowerDisplay.exe share a single lock-protected path. Add AddOrUpdateProfile, RenameAndUpdateProfile, RemoveProfile, and GetProfile as atomic helpers; split public methods into lock-free *Core variants called under _lock. ProfileService becomes a thin one-liner façade with no private state. PowerDisplayViewModel now calls single-method helpers instead of open-coding three-step ops. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All other entries in generateAllFileComponents.ps1 end the -depsPath argument with a backslash for consistency; the PowerDisplay entry was missing it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Remove blank line after single-line comment in ProfileHelper.cs (SA1512). Add using alias in ProfileService.cs to disambiguate ProfileHelper from PowerDisplay.Models vs the same-named class in PowerDisplay.Common.Utils (CS0117). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
- Check GPO disabled state early in Program.cs before instance registration - Gate all activation paths (toggle event, launch action, send_message) on IsActivationAllowed (GPO + module enabled) - Move StartToggleEventListener to enable() / StopToggleEventListener to disable() so the listener only runs while the module is active - Fix send_message bug that unconditionally set m_enabled = true when the process was not running Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… disable, AOT partial props - Wire rotation ComboBox: bind SelectedIndex TwoWay to SelectedRotationIndex, add IsEnabled binding and localized x:Uid strings for ComboBoxItem - Change tray icon trigger from WM_LBUTTONDBLCLK to WM_LBUTTONUP (single click) - Disable profile editor SettingsCards when monitor ToggleSwitch is off - Migrate [ObservableProperty] fields to partial property syntax (MVVMTK0045) - Add LangVersion=preview to PowerDisplay.csproj for MVVM Toolkit partial support Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
# Conflicts: # src/modules/powerdisplay/PowerDisplay.Lib/Utils/VcpNames.cs
Improve window placement logic to use coordinates relative to display area bounds, fixing issues with centering and bottom-right positioning on multi-monitor and high-DPI setups. Add _isShowingWindow flag to prevent unwanted auto-hide during activation. Remove redundant visibility checks. Adjust IdentifyWindow activation order for correct placement. Add clarifying comments and clean up helper methods.
Introduce DpiSuppressor to subclass WndProc and suppress WM_DPICHANGED during MoveAndResize, preventing double-scaling when moving windows across monitors with different DPI. Refactor HotkeyService to use a message handler instead of its own WndProc subclass, allowing both hotkey and DPI suppression logic to coexist. Update window positioning logic for accuracy, implement IDisposable for IdentifyWindow, and ensure proper disposal of resources. Improves multi-monitor DPI reliability and centralizes WndProc handling.
This comment has been minimized.
This comment has been minimized.
Removed enforcement of WindowMinHeightDip in window sizing logic. The window's height now adapts solely to content and available space, allowing it to shrink below the previous minimum. Adaptive max height calculation is also simplified to use only the work area ratio, improving responsiveness to screen size.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
moooyo
changed the title
lei9444
approved these changes
Apr 10, 2026
LegendaryBlair
added
the
Product-Display management
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Pull new code from this branch. Set up PowerDisplay.UI as startup project. Click run in VS.
Or, build whole solution, set up runner as startup project. Click run to test full experience.