Cleanup md files (root folder)#46582
Conversation
This comment has been minimized.
This comment has been minimized.
|
@Jay-o-Way Is this ready for review? Reviews were requested by the PR is still in draft so wanted to check :)!
|
|
Well, i wanted to change the headers too, but my quotum won't reset for another month. Maybe something you would like to add? Besides that, it's finished. |
I think overall it's looking good. It's just that some changes in the README are regressions, see my comments |
|
@niels9001 Thanks! Updated ReadMe. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
11f0073 to
a300774
Compare
This comment has been minimized.
This comment has been minimized.
|
It really is about the "details", haha. Fixed! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0a85d30 to
879baae
Compare
Co-Authored-By: Niels Laute <niels.laute@live.nl>
879baae to
9848e65
Compare
|
@niels9001 Thanks! I just applied the suggestions, and added the changes of PR 46371, and fixed conflicts. |
This comment has been minimized.
This comment has been minimized.
269fd9e to
9848e65
Compare
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (2)traies These words are not needed and should be removedLPCFHOOKPROC LUMA MAXDWORD MRT runtimeconfig suntimes timespan VSyncTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:Jay-o-Way/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/23850209647/attempts/1' &&
git commit -m 'Update check-spelling metadata'Warnings
|
| Count | |
|---|---|
| 5 |
See
If the flagged items are 🤯 false positives
If items relate to a ...
-
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txtfile matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^refers to the file's path from the root of the repository, so^README\.md$would exclude README.md (on whichever branch you're using). -
well-formed pattern.
If you can write a pattern that would match it,
try adding it to thepatterns.txtfile.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks @crutkas and @niels9001 ! Any advice for the point about putting licence texts inside a code block or not? Or not important? |
…46765) <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request See title Ref: #46582 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed


Summary of the Pull Request
Cleaning up Markdown files, including:
To do:
(Copilot quotum was reached 🤓)