Skip to content

Make several driver improvements#8025

Merged
jenshnielsen merged 24 commits intomicrosoft:mainfrom
qutech:enh/driver_improvements
Apr 13, 2026
Merged

Make several driver improvements#8025
jenshnielsen merged 24 commits intomicrosoft:mainfrom
qutech:enh/driver_improvements

Conversation

@thangleiter
Copy link
Copy Markdown
Contributor

Keysight 344xxA

  • Add SCPI mnemonics ('MIN', 'MAX', 'DEF') to allowed values where allowed

Oxford Mercury IPS

  • Allow setting current ramp rate and target

Oxford Triton

  • Also assume magnet is not available if there is a communication timeout

Yokagawa GS200

Programs

  • validate program times on multiples of the internal clock rate of 0.1s
  • only add trigger parameter if monitor option is installed
  • add get parser to count; allow setting to SCPI mnemonics 'MIN', 'MAX'.
  • add hold(), pause(), cont() methods.

Instrument

  • add parameters reading out device registers (status_byte, standard_event_register, extended_event_register, condition_register)
  • implement hardware ramps:
    • ramp_mode parameter switches the mode of output sets between "JUMP", "SOFTWARE", and "HARDWARE". The last uses a program to ramp, software corresponds to the previous ramp implementation.
    • ramp_step, ramp_rate, ramp_blocking configure the way ramps behave.

@thangleiter thangleiter requested a review from a team as a code owner April 8, 2026 14:00
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 59.45946% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.60%. Comparing base (ec90c0a) to head (622209a).
⚠️ Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
...odes/instrument_drivers/yokogawa/Yokogawa_GS200.py 62.35% 64 Missing ⚠️
...ers/Keysight/private/Keysight_344xxA_submodules.py 28.57% 10 Missing ⚠️
src/qcodes/instrument_drivers/oxford/triton.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8025      +/-   ##
==========================================
+ Coverage   70.26%   70.60%   +0.33%     
==========================================
  Files         333      333              
  Lines       32169    32486     +317     
==========================================
+ Hits        22604    22936     +332     
+ Misses       9565     9550      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jenshnielsen
Copy link
Copy Markdown
Collaborator

Thanks @thangleiter I think this looks good. Could you add a newsfragment with the new features and especially documenting the deprecations on the gs200.

@thangleiter
Copy link
Copy Markdown
Contributor Author

Thanks @jenshnielsen. Added the newsfragments, hope the formatting is ok.

@jenshnielsen
Copy link
Copy Markdown
Collaborator

Thanks @thangleiter other than the inline comment this should be good to land

@jenshnielsen jenshnielsen enabled auto-merge April 13, 2026 15:04
@jenshnielsen jenshnielsen added this pull request to the merge queue Apr 13, 2026
Merged via the queue into microsoft:main with commit b503346 Apr 13, 2026
17 of 18 checks passed
@thangleiter thangleiter deleted the enh/driver_improvements branch April 13, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants