-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Richfr/ Add windowsAddress support to WslcCreateContainer() API #40037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+180
−22
Merged
Changes from 6 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
fe043b9
Portmapping: add windowsAddress support
richfr 04a4541
Portmapping: add windowsAddress support
richfr cf34fb8
Addressing PR feedback: update wslcsdk.cpp
richfr 954d1a0
Addressing clang formatting error
richfr 31e28b4
Providing default values for port bindings: wslcsdk.cpp
richfr 7ca8e51
Merge branch 'feature/wsl-for-apps' into richfr/portmapping
1wizkid 7f1eca4
Merge branch 'feature/wsl-for-apps' into richfr/portmapping
1wizkid eff50d2
Fixed merge conflicts. Set default BindingAddress to 127.0.0.1. Valid…
richfr 41a39eb
Added new function InetNtopToHresult() to map inet result error value…
richfr 895a604
return family name if socket address is invalid
richfr a788da8
Removed unnecessasry variable bindingAddressStrings. Also, commented …
richfr 644ebab
Fixed clang formatting errors
richfr 47c28f2
Added WSLC Sdk API tests for WslcContainerPortMapping.windowsAddress …
richfr 9ed0f18
Add unique name to containerSettings var to make test debugging from …
richfr fb9c466
Adjust AF_UNIX portmapping test so that it fails if value accepted
richfr 13ba738
Return more accurate strncpy_s error result
richfr e482e48
Improved error return value of IP address verification
richfr 1e7656a
Merge branch 'feature/wsl-for-apps' into richfr/portmapping
1wizkid f4fd0ba
Merge branch 'feature/wsl-for-apps' into richfr/portmapping
1wizkid 45b6841
Merge branch 'feature/wsl-for-apps' into richfr/portmapping
1wizkid 75fa4ac
Provide better error reporting
richfr fdf802d
Merge branch 'feature/wsl-for-apps' into richfr/portmapping
1wizkid 573786f
Respond to misc copilot feedback
richfr 5a8a0ae
Merge branch 'richfr/portmapping' of https://github.com/microsoft/WSL…
richfr 7f2e047
Resolving merge after syncing with origin
richfr 6b5ffdd
Adjusted error messages
richfr dd50413
Removed 2 unnecessary lines of code
richfr 86eb5b7
Mark internal function as static to avoid external linkage
richfr 15c2e67
Merge branch 'feature/wsl-for-apps' into richfr/portmapping
1wizkid b9a3176
Merge branch 'feature/wsl-for-apps' into richfr/portmapping
1wizkid 9618aad
Delete diagnostics/trace01.etl
1wizkid 759f2f7
Delete diagnostics/trace02.etl
1wizkid 3e6f691
Remove ETL files and Add Ignore rule to .gitignore
richfr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.