.NET: [.NET] Fix Declarative Foreach dropping multi-field record values (fixes #6183)#6185
Open
hanhan761 wants to merge 1 commit into
Open
.NET: [.NET] Fix Declarative Foreach dropping multi-field record values (fixes #6183)#6185hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the ForeachExecutor to convert each table row directly to a formula value rather than extracting the first property's value before conversion.
Changes:
- Replaced
value.Properties.Values.First().ToFormula()withvalue.ToFormula()when materializing values from aTableDataValue.
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix \ForeachExecutor\ that collapsed multi-field records to only the first field's value in the loop value variable.
Changes
Issue
Fixes #6183
Verification
The existing tests in \ForeachExecutorTest.cs\ only build records with a single field, so they didn't catch this bug. The fix preserves the original behavior for single-field records while also correctly keeping all fields for multi-field records.