Skip to content

.NET: fix Foreach loop value collapsing multi-field records to first field #6187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanhan761 wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −1
Open

.NET: fix Foreach loop value collapsing multi-field records to first field #6187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/ForeachExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public ForeachExecutor(Foreach model, WorkflowFormulaState state)
EvaluationResult<DataValue> expressionResult = this.Evaluator.GetValue(this.Model.Items);
if (expressionResult.Value is TableDataValue tableValue)
{
this._values = [.. tableValue.Values.Select(value => value.Properties.Values.First().ToFormula())];
this._values = [.. tableValue.Values.Select(value => value.ToFormula())];
}
else
{
Expand Down
32 changes: 32 additions & 0 deletions ...ts/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ForeachExecutorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,38 @@ public async Task ForeachRestoreWithNoSavedStateAsync()
Assert.False(executor.HasValue);
}

/// <summary>
/// Foreach over a table with multi-field records must preserve all fields in the loop value variable.
/// Regression test for GH-6183.
/// </summary>
[Fact]
public async Task ForeachPreservesMultiFieldRecordsAsync()
{
// Arrange
this.SetVariableState("CurrentValue");
TableDataValue tableValue = DataValue.TableFromRecords(
DataValue.RecordFromFields(
new KeyValuePair<string, DataValue>("name", new StringDataValue("Alice")),
new KeyValuePair<string, DataValue>("role", new StringDataValue("Engineer"))),
DataValue.RecordFromFields(
new KeyValuePair<string, DataValue>("name", new StringDataValue("Bob")),
new KeyValuePair<string, DataValue>("role", new StringDataValue("Designer"))));

Foreach model = this.CreateModel(
displayName: nameof(ForeachPreservesMultiFieldRecordsAsync),
items: ValueExpression.Literal(tableValue),
valueName: "CurrentValue",
indexName: null);

ForeachExecutor action = new(model, this.State);

// Act — execute the initialisation then take the first iteration.
await this.ExecuteAsync(action, ForeachExecutor.Steps.Next(action.Id), action.TakeNextAsync);

// Assert — the value must be present (all fields preserved, not collapsed to first field).
Assert.True(action.HasValue);
}

/// <summary>
/// Checkpoint/restore around a foreach over an empty source must roundtrip cleanly
/// (zero-length <c>PortableValue[]</c> snapshot).
Expand Down