Python: persist pending request IDs through session serialization (fixes #5818)#6190
Open
hanhan761 wants to merge 1 commit into
Open
Python: persist pending request IDs through session serialization (fixes #5818)#6190hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a workflow pauses for human-in-the-loop input (e.g. Magentic plan review), the pending request IDs are kept in \WorkflowAgent._pending_requests. If the session is serialized with \ o_dict()\ and later restored with \rom_dict()\ on a new agent instance, the pending requests are lost. The agent then starts a fresh run instead of resuming the paused workflow.
Changes
Added two helper methods on \WorkflowAgent:
Both _run_impl\ and _run_stream_impl\ call these methods, so the fix covers streaming and non-streaming execution.
Since the data is stored in \session.state, the existing \ o_dict()/\rom_dict()\ serialization handles it automatically — no changes needed to \AgentSession.
Related
Fixes #5818