.NET: fix GetSessionAsync doc comment incorrectly stating null is returned (fixes #6082)#6191
Open
hanhan761 wants to merge 1 commit into
Open
.NET: fix GetSessionAsync doc comment incorrectly stating null is returned (fixes #6082)#6191hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
hanhan761
force-pushed
the
fix-6082-sessionstore-doc
branch
from
a614855 to
7c0d5c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The XML doc comment on AgentSessionStore.GetSessionAsync() states that the method returns
ull when the session is not found. However, the return type is ValueTask (non-nullable), and both existing implementations (noop session store, in memory session store) as well as the usage by AIHostAgent expect a new session to be returned instead of null.
This fix corrects the documentation to match the actual contract.
Issue
Fixes #6082
Verification