Python: include all usage detail fields in OTEL span attributes (fixes #5511)#6194
Open
hanhan761 wants to merge 1 commit into
Open
Python: include all usage detail fields in OTEL span attributes (fixes #5511)#6194hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Extends response usage attribute capture to include all integer usage metrics beyond just input/output tokens, emitting them as gen_ai.usage.* OpenTelemetry attributes.
Changes:
- Iterates over all
usage_detailsitems instead of only readinginput_token_countandoutput_token_count. - Maps known keys to existing
OtelAttr.INPUT_TOKENS/OtelAttr.OUTPUT_TOKENSattributes. - Emits any additional integer usage fields as
gen_ai.usage.<key>attributes.
Comment on lines
+2297
to
+2305
| for key, value in usage.items(): | ||
| if not isinstance(value, int): | ||
| continue | ||
| if key == "input_token_count": | ||
| attributes[OtelAttr.INPUT_TOKENS] = value | ||
| elif key == "output_token_count": | ||
| attributes[OtelAttr.OUTPUT_TOKENS] = value | ||
| else: | ||
| attributes[f"gen_ai.usage.{key}"] = value |
Comment on lines
+2297
to
+2299
| for key, value in usage.items(): | ||
| if not isinstance(value, int): | ||
| continue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_build_response_attributes()\ in \observability.py\ only extracts \input_token_count\ and \output_token_count\ from
esponse.usage_details. Any additional token counts set by providers (e.g. \cached_input_tokens,
easoning_tokens) are silently dropped from OTEL span attributes.
Changes
Replaced the hardcoded extraction of \input_token_count/\output_token_count\ with a loop over all integer-valued keys in \usage_details:
easoning_tokens) are set as \gen_ai.usage.\
Related
Fixes #5511