.NET: increase default search depth for script and resource discovery (fixes #5968)#6201
Open
hanhan761 wants to merge 1 commit into
Open
.NET: increase default search depth for script and resource discovery (fixes #5968)#6201hanhan761 wants to merge 1 commit into
hanhan761 wants to merge 1 commit into
Conversation
Comment on lines
+33
to
34
| private const int DefaultSearchDepth = 10; | ||
| private const int MaxSkillDirectorySearchDepth = 2; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increase the default
SearchDepthfor script and resource file discovery from 2 to 10, allowing the discovery of nested scripts/resources in deeper subdirectory structures.Background
AgentFileSkillsSourcealready supports recursive directory traversal viaScanDirectoryForScriptsandScanDirectoryForResources, but the default_searchDepthof 2 limits discovery to the root directory plus one level of subdirectories. Files nested deeper (e.g.,scripts/subdir/tool/my_script.py) are silently skipped.Fix
Changed
DefaultSearchDepthfrom 2 to 10. This allows discovery up to 10 levels of nesting while maintaining the existing security checks (symlink detection, path traversal prevention) and theSearchDepthconfiguration option for users who need different limits.Issue
Fixes #5968
Verification
AgentFileSkillsSourceScriptTests.cscover the default depth behaviorSearchDepthoption remains configurable viaAgentFileSkillsSourceOptions.SearchDepth