Skip to content

.NET: add FunctionApprovalResponseItemParam to fix unrecognized type discriminator (fixes #6006) #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanhan761 wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −0
Open

.NET: add FunctionApprovalResponseItemParam to fix unrecognized type discriminator (fixes #6006) #6203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/OpenAIHostingJsonUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ private static JsonSerializerOptions CreateDefaultOptions()
[JsonSerializable(typeof(MCPListToolsItemParam))]
[JsonSerializable(typeof(MCPApprovalRequestItemParam))]
[JsonSerializable(typeof(MCPApprovalResponseItemParam))]
[JsonSerializable(typeof(FunctionApprovalResponseItemParam))]
[JsonSerializable(typeof(MCPCallItemParam))]
[JsonSerializable(typeof(List<ItemParam>))]
// ItemContent types
Expand Down
1 change: 1 addition & 0 deletions dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Converters/ItemParamConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ internal sealed class ItemParamConverter : JsonConverter<ItemParam>
"mcp_list_tools" => doc.Deserialize(OpenAIHostingJsonContext.Default.MCPListToolsItemParam),
"mcp_approval_request" => doc.Deserialize(OpenAIHostingJsonContext.Default.MCPApprovalRequestItemParam),
"mcp_approval_response" => doc.Deserialize(OpenAIHostingJsonContext.Default.MCPApprovalResponseItemParam),
"function_approval_response" => doc.Deserialize(OpenAIHostingJsonContext.Default.FunctionApprovalResponseItemParam),
"mcp_call" => doc.Deserialize(OpenAIHostingJsonContext.Default.MCPCallItemParam),
_ => null // Ignore unknown types.
};
Expand Down
27 changes: 27 additions & 0 deletions dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Models/ItemParam.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,33 @@ internal sealed class MCPApprovalResponseItemParam : ItemParam
public string? Reason { get; init; }
}

/// <summary>
/// A function approval response item parameter.
/// This is a non-standard DevUI extension for human-in-the-loop scenarios.
/// </summary>
internal sealed class FunctionApprovalResponseItemParam : ItemParam
{
/// <summary>
/// The constant item type identifier for function approval response items.
/// </summary>
public const string ItemType = "function_approval_response";

/// <inheritdoc/>
public override string Type => ItemType;

/// <summary>
/// The unique identifier of the approval request being responded to.
/// </summary>
[JsonPropertyName("request_id")]
public required string RequestId { get; init; }

/// <summary>
/// Gets or sets a value indicating whether the function call was approved.
/// </summary>
[JsonPropertyName("approved")]
public bool Approved { get; init; }
}

/// <summary>
/// An MCP call item parameter.
/// </summary>
Expand Down