.NET: fix: preserve Foreach record values#6208
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes a bug in ForeachExecutor where iterating over a TableDataValue only exposed the first field of each record instead of the full record.
Changes:
- Replace
value.Properties.Values.First().ToFormula()withvalue.ToFormula()so the full record is yielded per iteration. - Add a unit test verifying multi-field records expose all fields via the loop variable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/ForeachExecutor.cs | Yield full record (not just first property) when iterating a table. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ForeachExecutorTest.cs | Adds test asserting all record fields are accessible from the iteration variable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6183.
Summary
RecordDataValueas a full record whenForeachmaterializes table rowsTo verify
dotnet test --project tests\Microsoft.Agents.AI.Workflows.Declarative.UnitTests\Microsoft.Agents.AI.Workflows.Declarative.UnitTests.csproj -f net10.0 -v Normal --filter-class Microsoft.Agents.AI.Workflows.Declarative.UnitTests.ObjectModel.ForeachExecutorTestdotnet test --project tests\Microsoft.Agents.AI.Workflows.Declarative.UnitTests\Microsoft.Agents.AI.Workflows.Declarative.UnitTests.csproj -f net472 -v Normal --filter-class Microsoft.Agents.AI.Workflows.Declarative.UnitTests.ObjectModel.ForeachExecutorTestdotnet format agent-framework-dotnet.slnx --verify-no-changes --no-restore --include src\Microsoft.Agents.AI.Workflows.Declarative\ObjectModel\ForeachExecutor.cs tests\Microsoft.Agents.AI.Workflows.Declarative.UnitTests\ObjectModel\ForeachExecutorTest.csgit diff --check