feat: one-command install with eager bundle priming#75
Merged
Conversation
Adds a curl-piped install script that: - Resolves the latest GitHub release tag via the API (mirrors update.py) - Runs uv tool install --reinstall --force from the resolved tag - Primes the bundle cache via amplifier-agent-post-install so first run is instant rather than 30-60s slow - Detects and directs the user to install missing prereqs (curl, uv); never silently bootstraps uv - Supports --tag <ref>, --no-prime, --yes (CI/non-TTY), --help flags - Bash 3.2 compatible (macOS floor); passes shellcheck with no errors Follows the one-line-installer-patterns skill conventions (rustup/deno/bun style): set -euo pipefail, IFS, mktemp-free, idempotent re-run, prints install location and uninstall command on success. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Rewrites the ## Install section to lead with the one-line curl installer and surfaces all supported install paths: - Recommended: curl | bash (installs latest tag, primes bundle cache) - Review-first: download then inspect before running - Pin a specific version: --tag v0.9.0 - Manual install: raw uv tool install + amplifier-agent-post-install - Installer flags table: --tag, --no-prime, --yes, --help - Update: amplifier-agent update (now also primes cache automatically) - Uninstall: uv tool uninstall + rm -rf ~/.amplifier-agent Preserves the note about first-run priming and the amplifier-agent update command, now cross-referenced to the new install script. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
After a successful uv tool install, runs amplifier-agent-post-install to prime the bundle cache. This closes the same gap as install.sh for existing users who upgrade: the first run after an update is now instant rather than pausing 30-60s on lazy bundle load. Changes: - Calls subprocess.run(["amplifier-agent-post-install"], check=False) after the install succeeds (subprocess already imported at line 21) - Prints "Priming bundle cache..." in the human-readable path only, so --output json stays machine-readable - Uses check=False: post-install is idempotent and always exits 0; failures log to stderr and never block the update from reporting success No new flags added; the priming step is intentionally always-on for update (there is no cost-benefit case for a --no-prime toggle here). 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Adds a dedicated workflow that triggers on changes to install.sh or the
workflow file itself (paths filter on both PR and main push).
Jobs:
shellcheck — installs shellcheck via apt and validates install.sh; any
SC warning or error fails the job, ensuring the script stays clean as
it evolves.
smoke-test — runs in a clean python:3.12-slim container with no
pre-installed uv. Installs prereqs (curl, ca-certificates, git) and
uv via the official astral.sh script, then exercises install.sh with
--no-prime --yes --tag v0.9.0 (pinned tag keeps test reproducible and
avoids GitHub API rate limits). Verifies the installed binary by
running amplifier-agent --help.
Workflow style matches ci.yml: actions/checkout@v4, concurrency cancel
group, timeout-minutes on each job.
🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)
Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the 30-60s "lazy bundle load on first run" gap by:
install.sh— a curl-piped installer that runsuv tool installthen primes the bundle cache (amplifier-agent-post-install) in one command.amplifier-agent-post-installinto the existingamplifier-agent updatecommand so updates re-prime the cache automatically.install.shand smoke-tests it in a clean container.The eager-priming infrastructure already existed (
amplifier-agent-post-installbinary inpyproject.toml, idempotent, always exits 0). This PR just surfaces it where users actually install and update.Motivation
On a fresh install,
amplifier-agent runlazily clones and pip-installs every module inbundle.mdon first use. That's 30-60s of opaque waiting on first run. This is a poor first impression — and unnecessary, sinceamplifier-agent-post-installalready exists for exactly this purpose. It was documented in code but not exposed in the install or update flow.What changes for users
uv tool install ...→ first run pauses 30-60scurl -fsSL .../install.sh | bash→ first run is instantamplifier-agent update→ next run pauses 30-60samplifier-agent update→ next run is instantamplifier-agent-post-installstepThe
--no-primeflag preserves the old behavior for users who want it (CI environments, offline installs).What's in the PR
install.sh(new)curl -fsSL ... | bash -s --convention/releases/latestAPI — same approach asupdate.py:50--tag <ref>,--no-prime,--yes,--helpset -euo pipefail, bash 3.2 compatible (macOS floor)uvand prints the official install command if missing — does not silently bootstrap uvuv tool install --reinstall --forceREADME.md(updated)Install section now leads with the one-liner, shows the review-first variant prominently, documents all flags, and includes update + uninstall.
src/amplifier_agent_cli/admin/update.py(3 lines)After successful
uv tool install --reinstall --force, callsamplifier-agent-post-install(idempotent, non-blocking). Echo message guarded to non-JSON output path so--output=jsonstays clean..github/workflows/install-script.yml(new)python:3.12-slimcontainer → installuv+git+curl→ runbash install.sh --no-prime --yes --tag v0.9.0→ verifyamplifier-agent --helpexits 0install.shor this workflowDecisions made (worth review)
main). Matchesupdate.pybehavior. Prereleases (wrapper-v*) are excluded automatically by the/releases/latestendpoint.--no-primeflag onamplifier-agent update. Keeping the update change to literally 3 lines. Users who really need to skip can setAMPLIFIER_AGENT_HOMEor just accept the priming cost.--no-primeso CI stays fast. The shellcheck job catches portability regressions; the smoke test verifies the install path works end-to-end.uv. Per the one-line-installer-patterns guidance: detect and direct, don't silently install someone else's package manager.gitin the container.uv tool install --from git+...requires git;python:3.12-slimdoesn't ship with it.Not in scope (reviewer can decide if needed)
docs/designs/YYYY-MM-DD-*.md— AGENTS.md mentions design docs for non-trivial changes. This was small and well-discussed in advance; can add a retrospective design doc if preferred.install.amplifier.dev) — usingraw.githubusercontent.com/...for now. Custom domain is a separate ops concern.Verification
shellcheck install.sh— cleanbash -n install.sh— cleanbash install.sh --help— exits 0 with usagepython -c "import ast; ast.parse(open('src/amplifier_agent_cli/admin/update.py').read())"— cleanTest plan post-merge
curl -fsSL https://raw.githubusercontent.com/microsoft/amplifier-agent/main/install.sh | bashand verify firstamplifier-agent runis instant.amplifier-agent updateand verify next run is instant.install.sh).