fix: add encoding='utf-8' to all text-mode file opens for non-English Windows compatibility#7966
Open
zzhzhangzhihao wants to merge 1 commit into
Open
Conversation
… Windows compatibility - page_logger.py: hash_path, call_tree_path, page_path - chat_completion_client_recorder.py: session_file_path (read/write) - _docker_jupyter.py: path (write) Fixes microsoft#5566
Contributor
|
@zzhzhangzhihao please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds explicit to all text-mode calls in the autogen-ext package that were missing it.
Why
On non-English Windows systems, the default file encoding is the system locale (e.g., GBK for Simplified Chinese). When the code tries to read/write text files without specifying UTF-8 encoding, it can cause:
The issue manifests when using components like:
Fix
Added to 6 file open calls across 3 files:
Related