Ensure Unique Query Parameters

[mikaelweave]

Description

Deduplicate query parameters when the exact key and value are passed in. Why?

• This is creating many duplicate CTEs causing extra database load
• Query parameters are a mathmatical set in FHIR
• A set of two of the exact same item is identical to a set of 1

Example

GET /Patient?_tag=system%7Ccode&_tag=system%7Ccode&_total=accurate in main generates

;WITH cte0 AS (
  SELECT ResourceTypeId AS T1, ResourceSurrogateId AS Sid1
  FROM dbo.TokenSearchParam
  WHERE SearchParamId = 1218
    AND SystemId = (SELECT SystemId FROM dbo.System WHERE Value = @p0)
    AND Code = @p1
    AND ResourceTypeId = 103
),
cte1 AS (
  SELECT ResourceTypeId AS T1, ResourceSurrogateId AS Sid1
  FROM dbo.TokenSearchParam
  WHERE EXISTS (SELECT * FROM cte0 WHERE ResourceTypeId = T1 AND ResourceSurrogateId = Sid1)
    AND SearchParamId = 1218
    AND SystemId = (SELECT SystemId FROM dbo.System WHERE Value = @p0)
    AND Code = @p1
    AND ResourceTypeId = 103
)

Related issues

AB#191513

Testing

• Locally
• Unit/Integration/E2E

FHIR Team Checklist

• Update the title of the PR to be succinct and less than 65 characters
• Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
• Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
• Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
• Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
• When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
• CI is green before merge
• Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.39%. Comparing base (6faa795) to head (6475987).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5557      +/-   ##
==========================================
- Coverage   77.63%   77.39%   -0.25%     
==========================================
  Files         985      993       +8     
  Lines       36189    36418     +229     
  Branches     5498     5518      +20     
==========================================
+ Hits        28097    28187      +90     
- Misses       6738     6869     +131     
- Partials     1354     1362       +8     

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.