Keep transaction cleanup independent of request cancellation#5574
Draft
mikaelweave wants to merge 1 commit into
Draft
Keep transaction cleanup independent of request cancellation#5574mikaelweave wants to merge 1 commit into
mikaelweave wants to merge 1 commit into
Conversation
Move the SqlServerFhirDataStore failed-transaction cleanup token change out of PR #5553 so it can be reviewed independently from the BundleHandler cancellation response mapping. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5574 +/- ##
==========================================
- Coverage 77.37% 77.34% -0.03%
==========================================
Files 993 993
Lines 36418 36418
Branches 5518 5518
==========================================
- Hits 28177 28169 -8
- Misses 6880 6887 +7
- Partials 1361 1362 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the SqlServerFhirDataStore failed-transaction cleanup token change out of #5553 for independent review.
Changes
SqlServerFhirDataStore.cs: passCancellationToken.NonetoMergeResourcesCommitTransactionAsyncin theMergeInternalAsyncsingle-transaction catch block.Testing
dotnet build src\Microsoft.Health.Fhir.SqlServer\Microsoft.Health.Fhir.SqlServer.csproj --verbosity minimalgit diff --checkRelated
Split from #5553 for ADO Bug #188321.