Skip to content

feat: Add hve-artifact-authoring skill to coding-standards collection#1678

Open
dmavroeid wants to merge 4 commits into
microsoft:mainfrom
dmavroeid:feat/1506-hve-artifact-authoring-skill
Open

feat: Add hve-artifact-authoring skill to coding-standards collection#1678
dmavroeid wants to merge 4 commits into
microsoft:mainfrom
dmavroeid:feat/1506-hve-artifact-authoring-skill

Conversation

@dmavroeid

Copy link
Copy Markdown

Summary

Adds the hve-artifact-authoring skill to the coding-standards collection alongside python-foundational.

The skill teaches frontmatter contracts, naming conventions, collection packaging, subagent delegation, and validation pipelines for authoring HVE Core artifacts.

Benchmark Evidence (blind A/B, 8 evals, 34 expectations)

Metric With Skill Baseline Delta
Mean pass rate 96% 43% +53%
Eval With Skill Baseline
create-orchestrator-agent 100% 0%
create-collection-package 100% 0%
design-alignment-delegation-model 100% 0%
create-full-workflow 100% 80%
create-instruction-auto-apply 100% 50%
design-alignment-artifact-hierarchy 100% 50%
design-alignment-validation-pipeline 67% 67%
add-skill-with-scripts 100% 100%

Model: Claude Opus 4.6 (1M context)

Acceptance Criteria

  • hve-artifact-authoring/SKILL.md present in coding-standards collection
  • All required frontmatter fields (name:, description:, version:)
  • validate:skills passes
  • Skill ≤ 500 lines

Closes #1506
Part of #1504

Adds the hve-artifact-authoring skill with 96% pass rate (vs 43% baseline)
in blind A/B evaluation across 8 evals and 34 expectations.

Closes microsoft#1506
@dmavroeid dmavroeid requested a review from a team as a code owner May 25, 2026 11:27
@dmavroeid dmavroeid self-assigned this May 25, 2026
@codecov-commenter

codecov-commenter commented May 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.49%. Comparing base (1102901) to head (939adf7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1678      +/-   ##
==========================================
- Coverage   85.50%   85.49%   -0.01%     
==========================================
  Files          82       82              
  Lines       11805    11805              
==========================================
- Hits        10094    10093       -1     
- Misses       1711     1712       +1     
Flag Coverage Δ
pester 83.65% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmavroeid

Copy link
Copy Markdown
Author

CI Notes on remaining failures:

  • Plugin Validation: Generated output in plugins/ and collections/*.collection.md is stale on main. Running npm run plugin:generate locally produces diffs beyond this PR's scope. Happy to include the full regeneration if preferred.
  • npm Security Audit: Pre-existing qs vulnerability (GHSA-q8mj-m7cp-5q26), unrelated to this PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the new hve-artifact-authoring skill to the coding-standards collection (and the aggregate hve-core-all collection), with accompanying generated plugin/collection documentation updates.

Changes:

  • Introduces the new skill package at .github/skills/coding-standards/hve-artifact-authoring/ (SKILL.md + reference + templates).
  • Registers the skill in collections/coding-standards.collection.yml and collections/hve-core-all.collection.yml.
  • Updates auto-generated collection/plugin READMEs to list the new skill.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
plugins/hve-core-all/README.md Updates plugin skill listing to include hve-artifact-authoring
plugins/coding-standards/README.md Updates plugin skill listing for coding-standards
collections/hve-core-all.collection.yml Adds the new skill to the aggregate collection manifest
collections/hve-core-all.collection.md Updates the aggregate collection’s auto-generated skill table
collections/coding-standards.collection.yml Adds the new skill to the coding-standards collection manifest
collections/coding-standards.collection.md Updates the coding-standards auto-generated skill table
.github/skills/coding-standards/hve-artifact-authoring/SKILL.md Adds the new skill’s primary documentation and guidance
.github/skills/coding-standards/hve-artifact-authoring/references/frontmatter-schemas.md Adds a frontmatter field reference doc
.github/skills/coding-standards/hve-artifact-authoring/assets/agent-template.md Adds a starter agent template
.github/skills/coding-standards/hve-artifact-authoring/assets/collection-template.yml Adds a starter collection manifest template
.github/skills/coding-standards/hve-artifact-authoring/assets/instruction-template.md Adds a starter instructions template
.github/skills/coding-standards/hve-artifact-authoring/assets/prompt-template.md Adds a starter prompt template
.github/skills/coding-standards/hve-artifact-authoring/assets/skill-template.md Adds a starter skill template

Comment on lines +101 to +105
| Skill | Description |
|------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| hve-artifact-authoring | Create, validate, and package AI artifacts for HVE Core, GitHub Copilot's prompt engineering framework. Covers agents, prompts, instructions, skills, and collections with frontmatter contracts, naming conventions, collection packaging, subagent delegation, workspace state tracking, and CI validation pipelines. Use when building any markdown-based AI artifact that follows the four-tier delegation model (Prompts → Agents → Instructions → Skills) with schema-validated frontmatter and collection-based distribution.
|
| python-foundational | Foundational Python best practices, idioms, and code quality fundamentals - Brought to you by microsoft/hve-core |
Comment on lines +540 to +544
| Skill | Description |
|---------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| hve-artifact-authoring | Create, validate, and package AI artifacts for HVE Core, GitHub Copilot's prompt engineering framework. Covers agents, prompts, instructions, skills, and collections with frontmatter contracts, naming conventions, collection packaging, subagent delegation, workspace state tracking, and CI validation pipelines. Use when building any markdown-based AI artifact that follows the four-tier delegation model (Prompts → Agents → Instructions → Skills) with schema-validated frontmatter and collection-based distribution.
|
| python-foundational | Foundational Python best practices, idioms, and code quality fundamentals - Brought to you by microsoft/hve-core |
Comment on lines +1 to +11
---
name: hve-artifact-authoring
description: >
Create, validate, and package AI artifacts for HVE Core, GitHub Copilot's prompt engineering
framework. Covers agents, prompts, instructions, skills, and collections with frontmatter
contracts, naming conventions, collection packaging, subagent delegation, workspace state
tracking, and CI validation pipelines. Use when building any markdown-based AI artifact that
follows the four-tier delegation model (Prompts → Agents → Instructions → Skills) with
schema-validated frontmatter and collection-based distribution.
version: 1.0.0
---
Comment on lines +160 to +166
```
<!-- <example-topic> -->
```code
[example]
```
<!-- </example-topic> -->
```
1. **Create directory:** `.github/skills/{collection-id}/{skill-name}/`

2. **Required structure:**
```
Comment on lines +6 to +7

## Inputs
Comment on lines +5 to +6

## Scope
* Guideline two

<!-- <example-topic1> -->
```
@@ -0,0 +1,47 @@
---
name: new-agent-name
kind: prompt
- path: .github/instructions/collection-id/instruction-name.instructions.md
kind: instruction
- path: .github/skills/collection-id/skill-name/SKILL.md

@bindsi bindsi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review (bindsi batch). The hve-artifact-authoring skill is a valuable meta-skill for creating HVE Core artifacts. The SKILL.md comprehensively covers all artifact types (agents, prompts, instructions, skills, collections) with proper frontmatter schemas, templates, and validation guidance. Collection wiring (coding-standards, hve-core-all) and plugin generation appear consistent.

No blocking functional, security, or correctness findings. The templates in assets/ provide good starter scaffolding. LGTM.

@bindsi bindsi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated batch review: no actionable findings.

@@ -571,6 +571,8 @@ items:
kind: instruction
- path: .github/instructions/shared/story-quality.instructions.md
kind: instruction

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the skill is declared maturity: stable in coding-standards.collection.yml, but this entry in hve-core-all.collection.yml omits the maturity field. Per the skill's own documentation, item-level maturity overrides collection-level maturity, so the omission could expose or suppress the skill across distribution channels differently than intended.

- path: .github/skills/coding-standards/hve-artifact-authoring
  kind: skill
  maturity: stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add hve-artifact-authoring skill to coding-standards collection

5 participants