Skip to content

Fix: prevent needrestart prompt from hanging CVM attestation tool ins… #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SRIKKANTH wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

Fix: prevent needrestart prompt from hanging CVM attestation tool ins… #4607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lisa/microsoft/testsuites/cvm/cvm_attestation_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,24 @@ def _clone_repo(self) -> None:

def _install(self) -> bool:
self._clone_repo()
# install.sh runs apt via its own inner `sudo`, which resets the
# environment and drops NEEDRESTART_MODE/DEBIAN_FRONTEND. On Ubuntu
# 22.04+ that makes needrestart show the interactive "Which services
# should be restarted?" dialog, hanging the install until it times out.
# Force needrestart into automatic mode by appending the setting to the
# end of its config file (last assignment wins in the perl config);
# this is read from disk and so survives the inner sudo.
needrestart_conf = "/etc/needrestart/needrestart.conf"
self.node.execute(
"sudo ./install.sh",
f"test -f {needrestart_conf} && "
f"echo '$nrconf{{restart}} = \"a\";' >> {needrestart_conf} || true",
shell=True,
Comment on lines +112 to 116
sudo=True,
)
self.node.execute(
"./install.sh",
shell=True,
sudo=True,
cwd=self.attestation_dir,
)
return self._check_exists()
Expand Down
Loading