Skip to content

fix: guard against missing oMath element in DOCX math converter (#1979) #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanhan761 wants to merge 1 commit into
base: main
Choose a base branch
from
+65 −0
Open

fix: guard against missing oMath element in DOCX math converter (#1979) #1995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/markitdown/src/markitdown/converter_utils/docx/pre_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ def _convert_omath_to_latex(tag: Tag) -> str:
math_root = ET.fromstring(MATH_ROOT_TEMPLATE.format(str(tag)))
# Find the 'oMath' element within the XML document
math_element = math_root.find(OMML_NS + "oMath")
if math_element is None:
return ""
# Convert the 'oMath' element to LaTeX using the oMath2Latex function
latex = oMath2Latex(math_element).latex
return latex
Expand Down
63 changes: 63 additions & 0 deletions packages/markitdown/tests/test_module_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,69 @@ def test_docx_equations() -> None:
assert block_equations, "No block equations found in the document."


def test_docx_malformed_equations() -> None:
"""Malformed equations should not crash the converter (issue #1979)."""
import zipfile
from io import BytesIO

docx_xml = """<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<w:document xmlns:m="http://schemas.openxmlformats.org/officeDocument/2006/math"
xmlns:w="http://schemas.openxmlformats.org/wordprocessingml/2006/main"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
mc:Ignorable="w14 wp14">
<w:body>
<w:p>
<w:r><w:t>Normal text</w:t></w:r>
</w:p>
<m:oMathPara>
<m:oMath>
<m:r><m:t>x+1</m:t></m:r>
</m:oMath>
</m:oMathPara>
<w:p>
<w:r><w:t>After good equation</w:t></w:r>
</w:p>
<m:oMathPara>
<!-- oMathPara with no oMath child -->
</m:oMathPara>
<w:p>
<w:r><w:t>After empty oMathPara</w:t></w:r>
</w:p>
<m:oMath>
<!-- empty inline oMath -->
</m:oMath>
<w:p>
<w:r><w:t>After empty inline oMath</w:t></w:r>
</w:p>
</w:body>
</w:document>"""

buf = BytesIO()
with zipfile.ZipFile(buf, "w") as z:
z.writestr("word/document.xml", docx_xml.encode("utf-8"))
z.writestr("[Content_Types].xml", """<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types">
<Default Extension="rels" ContentType="application/vnd.openxmlformats-package.relationships+xml"/>
<Default Extension="xml" ContentType="application/xml"/>
<Override PartName="/word/document.xml" ContentType="application/vnd.openxmlformats-officedocument.wordprocessingml.document.main+xml"/>
</Types>""")
z.writestr("word/_rels/document.xml.rels", """<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships">
</Relationships>""")
z.writestr("_rels/.rels", """<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships">
<Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/officeDocument" Target="word/document.xml"/>
</Relationships>""")

buf.seek(0)
markitdown = MarkItDown()
result = markitdown.convert(buf)
assert "Normal text" in result.text_content
assert "$x+1$" in result.text_content or "$$x+1$$" in result.text_content
assert "After empty oMathPara" in result.text_content
assert "After empty inline oMath" in result.text_content


def test_input_as_strings() -> None:
markitdown = MarkItDown()

Expand Down