fix: catch UnicodeDecodeError in IpynbConverter.accepts() for non-ASCII files#2018
Open
AyushPramanik wants to merge 1 commit into
Open
fix: catch UnicodeDecodeError in IpynbConverter.accepts() for non-ASCII files#2018AyushPramanik wants to merge 1 commit into
AyushPramanik wants to merge 1 commit into
Conversation
…II files When a non-ASCII file (e.g. a French PDF) has a JSON MIME type, the decode call in accepts() would raise UnicodeDecodeError and crash the entire conversion pipeline. accepts() should never raise — return False instead when the content cannot be decoded. Fixes microsoft#1894. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IpynbConverter.accepts()crashed the entire conversion pipeline withUnicodeDecodeErrorwhen encountering non-ASCII files (e.g. French PDFs withé,è,àcharacters) whose MIME type starts withapplication/json.try/finallyblock decoded the file stream but had noexcept, so the error propagated uncaught.except (UnicodeDecodeError, ValueError): return Falseso non-decodable files are gracefully rejected instead of crashing.Fixes #1894.
Test plan
UnicodeDecodeError.ipynbnotebook — should still work correctlyapplication/jsonMIME type that is not a notebook — should returnFalsegracefully🤖 Generated with Claude Code