Skip to content

fix: remove mammoth dependency exception handling #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doitgo wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −5
Open

fix: remove mammoth dependency exception handling #2025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4958408
fix: remove mammoth dependency exception handling
doitgo May 31, 2026
fa85621
fix: initialize md_text before conditional blocks in RSS converter (#…
doitgo May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/markitdown/src/markitdown/converters/_plain_text_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@
# Try loading optional (but in this case, required) dependencies
# Save reporting of any exceptions for later
_dependency_exc_info = None
try:
import mammoth # noqa: F401
except ImportError:
# Preserve the error and stack trace for later
_dependency_exc_info = sys.exc_info()

ACCEPTED_MIME_TYPE_PREFIXES = [
"text/",
Expand Down
1 change: 1 addition & 0 deletions packages/markitdown/src/markitdown/converters/_rss_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ def _parse_rss_type(self, doc: Document) -> DocumentConverterResult:
channel_title = self._get_data_by_tag_name(channel, "title")
channel_description = self._get_data_by_tag_name(channel, "description")
items = channel.getElementsByTagName("item")
md_text = ""
if channel_title:
md_text = f"# {channel_title}\n"
if channel_description:
Expand Down