Allow KQL comments and let statements (#2385)#2387
Merged
xiangyan99 merged 2 commits intorelease/azure/2.xfrom Apr 10, 2026
Merged
Allow KQL comments and let statements (#2385)#2387xiangyan99 merged 2 commits intorelease/azure/2.xfrom
xiangyan99 merged 2 commits intorelease/azure/2.xfrom
Conversation
* Allow KQL comments and let statements * updates
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Kusto tool’s KQL query validation to support more idiomatic KQL authoring by allowing // comments and semicolon-separated let statements, while still blocking known-dangerous management commands and tautology-based injections.
Changes:
- Allow
//comments in KQL inputs (previously rejected). - Allow semicolons/
letstatements by removing the “multiple statements” rejection. - Replace management-command detection with a whitespace-tolerant regex check (including tabs/newlines).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Kusto/src/Validation/KqlQueryValidator.cs | Removes comment/semicolon blocking and switches management-command detection to a regex-based approach. |
| tools/Azure.Mcp.Tools.Kusto/tests/Azure.Mcp.Tools.Kusto.UnitTests/KqlQueryValidatorTests.cs | Updates/extends unit tests to reflect newly-allowed comments and semicolons and adds whitespace variants for management-command detection. |
| servers/Azure.Mcp.Server/changelog-entries/1775838003897.yaml | Adds a changelog entry describing the KQL validator behavior changes. |
KarishmaGhiya
approved these changes
Apr 10, 2026
danield137
requested changes
Apr 10, 2026
danield137
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow KQL comments and let statements
updates
What does this PR do?
[Provide a clear, concise description of the changes][Add additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline