Skip to content

Allow KQL comments and let statements (#2385)#2387

Merged
xiangyan99 merged 2 commits intorelease/azure/2.xfrom
kusto_let_comment_2.x
Apr 10, 2026
Merged

Allow KQL comments and let statements (#2385)#2387
xiangyan99 merged 2 commits intorelease/azure/2.xfrom
kusto_let_comment_2.x

Conversation

@xiangyan99
Copy link
Copy Markdown
Member

  • Allow KQL comments and let statements

  • updates

What does this PR do?

[Provide a clear, concise description of the changes]

[Add additional context, screenshots, or information that helps reviewers]

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

* Allow KQL comments and let statements

* updates
@xiangyan99 xiangyan99 requested review from a team, danield137 and prvavill as code owners April 10, 2026 22:57
Copilot AI review requested due to automatic review settings April 10, 2026 22:57
@xiangyan99 xiangyan99 requested review from alzimmermsft, chidozieononiwu, conniey, jairmyree, joshfree, msalaman and wbreza and removed request for a team April 10, 2026 22:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Kusto tool’s KQL query validation to support more idiomatic KQL authoring by allowing // comments and semicolon-separated let statements, while still blocking known-dangerous management commands and tautology-based injections.

Changes:

  • Allow // comments in KQL inputs (previously rejected).
  • Allow semicolons/let statements by removing the “multiple statements” rejection.
  • Replace management-command detection with a whitespace-tolerant regex check (including tabs/newlines).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tools/Azure.Mcp.Tools.Kusto/src/Validation/KqlQueryValidator.cs Removes comment/semicolon blocking and switches management-command detection to a regex-based approach.
tools/Azure.Mcp.Tools.Kusto/tests/Azure.Mcp.Tools.Kusto.UnitTests/KqlQueryValidatorTests.cs Updates/extends unit tests to reflect newly-allowed comments and semicolons and adds whitespace variants for management-command detection.
servers/Azure.Mcp.Server/changelog-entries/1775838003897.yaml Adds a changelog entry describing the KQL validator behavior changes.

Comment thread tools/Azure.Mcp.Tools.Kusto/src/Validation/KqlQueryValidator.cs
@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server Apr 10, 2026
@xiangyan99 xiangyan99 requested a review from danield137 April 10, 2026 23:22
@xiangyan99 xiangyan99 merged commit c2f4c69 into release/azure/2.x Apr 10, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Apr 10, 2026
@xiangyan99 xiangyan99 deleted the kusto_let_comment_2.x branch April 10, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants