Fix memory leaks in webpack plugin from repeated worker compilation#4938
Open
dgaponov wants to merge 4 commits into
Open
Fix memory leaks in webpack plugin from repeated worker compilation#4938dgaponov wants to merge 4 commits into
dgaponov wants to merge 4 commits into
Conversation
Add alreadyCompiled flag to prevent unnecessary worker rebuilds during development with Hot Module Replacement, which was causing memory leaks in both webpack and rspack.
Author
|
@microsoft-github-policy-service agree |
Author
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In development mode with Hot Module Replacement (HMR) enabled, workers were being recompiled on every change, leading to memory leaks. This issue was particularly problematic in rspack environments where repeated compilation cycles would cause significant memory accumulation.
web-infra-dev/rspack#8976 (comment)
Root Cause
The
AddWorkerEntryPointPluginwas creating new child compilers for worker entry points on every compilation cycle without tracking whether the worker had already been compiled. This resulted in:Solution
alreadyCompiledflag to track compilation stateChanges
getCompilerHookfunction to include compilation trackingTesting
Impact
Fixes memory leak issues reported in development environments using HMR with worker entry points.