Open
Conversation
- Change executor to create one connection (unique QP) per channel entry instead of sharing connections per peer. This is required for HostNoAtomic IB mode where each connection can only forward signals to one semaphore via setSignalForwardingDst. - Add MSCCLPP_IB_GID_INDEX environment variable to override the default GID index (3) used for IB transport. Set to the desired GID index value, or leave unset/-1 to use the default.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add ibGidIndex to Env (default 0) - Change DefaultGidIndex to -1 (unspecified) - Resolve in endpoint.cc: explicit value >= 0 takes priority, otherwise use env Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an environment-variable override for the InfiniBand GID index used when creating IB queue pairs, so deployments can tune GID selection without recompiling or changing call sites.
Changes:
- Introduces
MSCCLPP_IB_GID_INDEXin the globalEnvand logs it when set. - Resolves
EndpointConfig::Ib::gidIndexfrom the env var when the config value is unspecified (sentinel). - Exposes the new env value through the Python
CppEnvbindings and updates the public default/sentinel inEndpointConfig::Ib.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/core/env.cpp |
Reads and logs MSCCLPP_IB_GID_INDEX into the global environment object. |
src/core/endpoint.cc |
Applies env-based fallback for gidIndex before creating IB QPs. |
python/csrc/env_py.cpp |
Exposes ib_gid_index via nanobind. |
include/mscclpp/env.hpp |
Adds Env::ibGidIndex with documentation for the new env var. |
include/mscclpp/core.hpp |
Changes EndpointConfig::Ib default GID index sentinel and documents env fallback behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use MSCCLPP_IB_GID_INDEX to control ib gid index