Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds CI coverage for the DSL executor by introducing a dedicated Azure Pipelines job that runs executor validation against a set of newly added “golden” execution plans generated from accompanying algorithm definitions.
Changes:
- Added multiple executor test plans (JSON) covering pack/unpack, reduce, TBG, and NVLS scenarios.
- Added Python algo generators corresponding to those plans (including TBG and NVLS pipeline variants).
- Added a new Azure Pipelines job + reusable template to deploy H100 runners and execute the executor test suite remotely.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/executor-tests/exeuction-plans/transfer_pack_tbg.json | Adds a TBG variant execution plan for transfer pack test coverage. |
| test/executor-tests/exeuction-plans/transfer_pack.json | Adds baseline transfer pack execution plan used by executor tests. |
| test/executor-tests/exeuction-plans/reduce_tbg.json | Adds TBG allreduce(Simple) plan to validate grouped TB execution. |
| test/executor-tests/exeuction-plans/reduce_pack_tbg.json | Adds TBG allreduce(LL packet) plan for packetized reduce paths. |
| test/executor-tests/exeuction-plans/reduce_pack.json | Adds baseline allreduce(LL packet) plan for executor validation. |
| test/executor-tests/exeuction-plans/reduce_nvls_pipeline.json | Adds NVLS pipeline plan to test loop/pipeline execution in executor. |
| test/executor-tests/exeuction-plans/reduce_nvls.json | Adds NVLS non-pipelined plan to test switch-channel reduce/broadcast. |
| test/executor-tests/exeuction-plans/reduce.json | Adds baseline allreduce(Simple) plan with fused instruction sequence. |
| test/executor-tests/algos/transfer_pack_tbg.py | Adds generator for transfer pack plan using thread block groups. |
| test/executor-tests/algos/transfer_pack.py | Adds generator for transfer pack plan (non-TBG). |
| test/executor-tests/algos/reduce_tbg.py | Adds generator for reduce(Simple) plan using thread block groups. |
| test/executor-tests/algos/reduce_pack_tbg.py | Adds generator for reduce(LL packet) plan using thread block groups. |
| test/executor-tests/algos/reduce_pack.py | Adds generator for reduce(LL packet) plan (non-TBG). |
| test/executor-tests/algos/reduce_nvls_pipeline.py | Adds generator for NVLS pipeline plan using SwitchChannel + loop context. |
| test/executor-tests/algos/reduce_nvls.py | Adds generator for NVLS plan using SwitchChannel reduce/broadcast. |
| test/executor-tests/algos/reduce.py | Adds generator for reduce(Simple) plan with instruction fusion. |
| .azure-pipelines/ut.yml | Adds a new CI job to run DSL executor tests on H100 pool. |
| .azure-pipelines/templates/ut-executor.yml | Introduces a reusable template to deploy, run executor tests, and stop VMSS. |
c0aca60 to
94f1f1a
Compare
chhwang
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.