Repository navigation
Fix .NET captured execution timeout cleanup - #1613
Merged
Merged
Conversation
This PR fixes captured execution that can wait indefinitely after a workload timeout when a descendant keeps an output pipe open. Details * Close output readers on timeout and return the collected partial output. * Report reader-close failures without waiting on the blocked readers. * Add a typed IsolationSession regression and document the capture behavior. Tests * C# syntax and git diff checks passed. * The regression is in the existing scheduled IsolationSession test class. * dotnet build --no-restore --nologo -v:q was blocked by NETSDK1004. The host-dependent runtime regression was not run locally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 38bb56f2-debb-4e64-a7a1-574321a83b89 Generated-with: gpt-6.1-sol
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The Windows IsolationSession regression has not run on a supported live host, leaving native pipe-read interruption, bounded completion, and retention of partial output unverified.
No open issues 🎉
What changed in this PR
Fixes .NET captured execution hanging after a timeout when a descendant keeps an output pipe open.
Changes:
- Closes output readers on timeout and returns collected partial output.
- Reports reader-close failures without waiting for blocked readers.
- Adds an IsolationSession regression and documents timeout capture behavior.
Validation remains incomplete: the reported build was blocked by NETSDK1004, and the host-dependent regression was not run locally.
| File | Description |
|---|---|
sdk/dotnet/Microsoft.Mxc.Sdk/V1/MxcProcess.cs |
Adds timeout reader cleanup and close-failure handling. |
sdk/dotnet/Microsoft.Mxc.Sdk.Tests/V1/MxcLifecycleE2ETests.cs |
Adds regression coverage for descendant-held output pipes. |
docs/api-reference/dotnet/v1/api.md |
Documents partial-output capture on timeout. |
Review effort: Balanced
Soham Das (SohamDas2021)
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes captured execution that can wait indefinitely after a workload timeout when a descendant keeps an output pipe open.
Details
Tests
Microsoft Reviewers: Open in CodeFlow