[CoreML EP] Support bool Cast in ML Program#28595
Draft
maxwbuckley wants to merge 3 commits into
Draft
Conversation
Two changes to the ML Program Cast builder: 1. Accept BOOL as a source and target dtype in HasSupportedInputsImpl. The ML Program `cast` op already handles bool, and AddToModelBuilderImpl already maps `to == BOOL`; only the input/output type gate omitted it. This lets int64<->bool<->float casts (transformer attention-mask graphs) stay on CoreML. 2. Move the "no preceding node" check after the ML Program early-return. It was legacy gating for the NeuralNetwork ArgMax-only path (which dereferences InputEdgesBegin()); on the ML Program path a Cast fed directly by a graph input is fine, and rejecting it forced needless CPU fallback. Tests (coreml_basic_test.cc): - CastBoolRoundTrip_MLProgram: an int64->bool->float cast chain runs fully on CoreML and matches the CPU reference. The bool tensor is internal (a CoreML partition cannot have bool I/O) and the first Cast is graph-input fed. - CastNonArgMaxNeuralNetworkNotSupported: the same chain falls back to CPU on the NeuralNetwork format, guarding the IsOpSupportedImpl reordering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 20, 2026
CastBoolRoundTrip_MLProgram exercised int64 -> Cast(bool) -> Cast(float). CoreML's compiler fuses the two back-to-back `cast` ops and drops the bool clamp (cast(cast(x,bool),fp32) collapses to cast(x,fp32)), so the round-trip produces the raw input value instead of 0/1 -- the test can't be numerically verified standalone. The bool-Cast support itself is correct: it is exercised end to end by the dependent PRs, where a non-Cast op sits between the int<->bool casts so no fusion occurs -- Cast->And->Cast (Where/And PR) and Cast->GatherND->Cast (GatherND PR), both numerically verified against the CPU EP. CastNonArgMaxNeuralNetworkNotSupported (the NeuralNetwork-format negative test) is kept; it guards the IsOpSupportedImpl reordering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes to the ML Program
Castbuilder:BOOLas a source and target dtype inHasSupportedInputsImpl. TheML Program
castop already handles bool, andAddToModelBuilderImplalreadymaps
to == BOOL; only the input/output type gate omitted it.check is legacy gating for the NeuralNetwork ArgMax-only path (which
dereferences
InputEdgesBegin()); on the ML Program path aCastfed directlyby a graph input is fine, and rejecting it forced needless CPU fallback.
Why
This is the first of a 4-PR series giving the CoreML EP the op coverage to run
transformer and diffusion graphs as a single CoreML partition instead of
fragmenting across CPU.
Transformer attention-mask graphs are a
Cast → GatherND → And → Wherechain overbool tensors. A CoreML partition cannot have a bool input/output (CoreML
MLMultiArrayhas no bool type), so bool must stay internal — which makesCast(the int↔bool boundary) the prerequisite for the rest of the series.
Combined impact of the series
With all four PRs plus #28278 (scalar-
Gather), every model below goes from 2CoreML partitions to 1, with zero graph breaks — the whole graph runs on
CoreML. Measured on an Apple M3 Max, ML Program format:
The op builders eliminate the graph breaks (deterministic); the speedups are what
CoreML already delivers once a model is no longer fragmented.
Tests (
coreml_basic_test.cc)CastNonArgMaxNeuralNetworkNotSupported— anint64 → bool → floatcast chainfalls back to CPU on the NeuralNetwork format, guarding the
IsOpSupportedImplreordering.
Positive
bool-Cast coverage is in the dependent PRs:Cast → GatherND → Cast(#28598's
GatherNDBoolData_MLProgram) andCast → And → Cast(#28597'sAnd_MLProgram). Both place a non-Castop between the int↔bool casts and checkthe result against the CPU EP. A standalone
int64 → Cast(bool) → Cast(float)round-trip can't be verified here — CoreML's compiler fuses back-to-back
castops and drops the bool clamp — so the pattern needs that intervening op, which
only the dependent PRs provide.
Series — CoreML EP coverage for transformer / diffusion graphs
Together with #28278 (scalar-
Gather), the series takes BERT / GPT-2 / ViT /diffusion-UNet graphs — tiny and full-size — from 2 CoreML partitions to 1, with
zero graph breaks.