-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add component governance manifest for WebGPU EP #28599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adrastogi
wants to merge
3
commits into
main
Choose a base branch
from
adrastogi/webgpu-cg-manifest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,326
−1
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| # CGManifest Files | ||
| This directory contains CGManifest (cgmanifest.json) files. | ||
| See [here](https://docs.opensource.microsoft.com/tools/cg/cgmanifest.html) for details. | ||
| See [here](https://docs.opensource.microsoft.com/tools/cg/cgmanifest.html) for details. | ||
|
|
||
| The WebGPU-specific manifest is in `webgpu/cgmanifest.webgpu.json`. It is intentionally not named `cgmanifest.json` | ||
| so default whole-repository Component Governance scans do not pick it up automatically. WebGPU packaging or | ||
| NOTICE-generation pipelines should stage it as `cgmanifest.json` in their scan input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # WebGPU Component Governance manifest | ||
|
|
||
| This directory contains the WebGPU-specific Component Governance manifest for ONNX Runtime. It covers Dawn and the | ||
| Dawn-derived dependency graph used when building the WebGPU Execution Provider. | ||
|
|
||
| The manifest is named `cgmanifest.webgpu.json`, not `cgmanifest.json`, so default whole-repository Component | ||
| Governance scans do not pick it up automatically. WebGPU packaging and NOTICE-generation pipelines should stage or copy | ||
| this file as `cgmanifest.json` in the source directory that they scan for WebGPU package notices. | ||
|
|
||
| ## Classification policy | ||
|
|
||
| The Component Governance manifest schema provides a `developmentDependency` boolean, but it does not provide separate | ||
| first-class fields for runtime, build-tool, test-only, or conditional dependencies. This manifest uses: | ||
|
|
||
| - no `developmentDependency` field for components that are redistributed, statically linked, or otherwise part of the | ||
| WebGPU package/runtime dependency closure; | ||
| - `developmentDependency: true` for Dawn dependencies that are only build tools, tests, disabled optional backends, or | ||
| source inputs that current WebGPU packages do not redistribute; | ||
| - `comments` to preserve the more precise classification and Dawn `DEPS` path/condition. | ||
|
|
||
| If a WebGPU package starts redistributing a component currently marked as a development dependency, update that | ||
| registration and explain the packaging path in `comments` and `detectedComponentLocations`. | ||
|
|
||
| ## Maintenance | ||
|
|
||
| When rolling Dawn or changing WebGPU packaging: | ||
|
|
||
| 1. Update the Dawn registration to match the `dawn` entry in `cmake/deps.txt`. | ||
| 2. Re-audit the pinned upstream Dawn `DEPS` file. Compare the Dawn dependency list against this manifest, update any | ||
| changed commits or repository URLs, and reclassify entries if ORT's WebGPU build starts or stops redistributing | ||
| them. | ||
| 3. If the Windows WebGPU plugin pipeline changes the downloaded DXC release, update the DirectXShaderCompiler release | ||
| registration to match `tools/ci_build/github/azure-pipelines/stages/plugin-win-webgpu-stage.yml`. | ||
| 4. Run: | ||
|
|
||
| ```powershell | ||
| python cgmanifests\webgpu\validate_webgpu_cgmanifest.py | ||
| ``` | ||
|
|
||
| The validator checks for stale Dawn and DXC pins, but it does not replace the manual dependency classification review | ||
| in step 2. | ||
|
|
||
| Non-git Dawn toolchain packages from CIPD/GCS, such as GN, Ninja, CMake, Go, Siso, reclient, and sysroots, are | ||
| intentionally not registered here unless they become redistributed or CG/legal guidance requires build input coverage. | ||
| They do not have stable public upstream source identities in the Dawn `DEPS` file and are not part of current WebGPU | ||
| package contents. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the one we're downloading different from Dawn's DirectXShaderCompiler commit?
https://github.com/google/dawn/blob/ec7b457e5bb1fcec6f59733c4f3dd84d2f885a38/DEPS#L373
@guschmue do you know?