Skip to content

Fix upsample half pixel mode for size one #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PrithviBadiga wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Fix upsample half pixel mode for size one #2918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion onnxscript/function_libs/torch_lib/ops/nn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2320,7 +2320,7 @@ def aten_unflatten_dense_tensors(


def _get_upsample_align_corners_mode(align_corners: bool) -> str:
return "align_corners" if align_corners else "pytorch_half_pixel"
return "align_corners" if align_corners else "half_pixel"


def _aten_upsample_output_size(
Expand Down
6 changes: 6 additions & 0 deletions tests/function_libs/torch_lib/extra_opinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1887,6 +1887,9 @@ def shape(size, rank, with_batch_channel=True):
yield opinfo_core.SampleInput(make_arg(shape(D, rank)), shape(SS, rank, False), True)

for align_corners in align_corners_options:
yield opinfo_core.SampleInput(
make_arg(shape(D, rank)), shape(1, rank, False), align_corners
)
yield opinfo_core.SampleInput(
make_arg(shape(D, rank)), shape(S, rank, False), align_corners
)
Expand Down Expand Up @@ -1934,6 +1937,9 @@ def shape(size, rank, with_batch_channel=True):
yield opinfo_core.SampleInput(make_arg(shape(D, rank)), shape(SS, rank, False), True, None)

for align_corners in align_corners_options:
yield opinfo_core.SampleInput(
make_arg(shape(D, rank)), shape(1, rank, False), align_corners, None
)
yield opinfo_core.SampleInput(
make_arg(shape(D, rank)), shape(S, rank, False), align_corners, None
)
Expand Down