chore: retarget video and overlay to screencast api#39915
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Mar 28, 2026
Merged
chore: retarget video and overlay to screencast api#39915pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
yury-s
approved these changes
Mar 28, 2026
|
|
||
| async showOverlay(html: string, options?: { duration?: number }): Promise<DisposableStub> { | ||
| const { id } = await this._page._channel.overlayShow({ html, duration: options?.duration }); | ||
| return new DisposableStub(() => this._page._channel.overlayRemove({ id })); |
Member
There was a problem hiding this comment.
can you make the callback async to make it clear that the caller will await?
pavelfeldman
force-pushed
the
retarget_video
branch
from
b948a8d to
9c3c6fc
Compare
pavelfeldman
force-pushed
the
retarget_video
branch
from
9c3c6fc to
258832a
Compare
Contributor
Test results for "tests 1"1 flaky39044 passed, 845 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 6279 passed, 350 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.