feat(devices): add iPhone 16 and iPhone 17 device families#40917
feat(devices): add iPhone 16 and iPhone 17 device families#40917dimkin-eu wants to merge 1 commit into
Conversation
|
@microsoft-github-policy-service agree |
|
Would like to add foldables (Galaxy Z Fold / Z Flip) in a follow-up or in the same PR. Each device has a cover (external, narrow) display and an inner display - the cover one is the main use case for me. Together, that's 2 screens × portrait + landscape = up to 4 entries per device, and there's no foldable precedent in
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
522cf04 to
400a329
Compare
This one looks good to me. |
|
@dimkin-eu Sorry for the inconvenience, but this needs a rebase. There have been changes both to the device list, and to the chromium version, and all of that conflicts with your PR, unfrotunately. |
400a329 to
49671a2
Compare
rebased
will do in new PR |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "MCP"1 failed 7180 passed, 1113 skipped Merge workflow run. |
Test results for "tests 1"1 flaky42042 passed, 850 skipped Merge workflow run. |
9fe0d9a to
cc82c5a
Compare
Add portrait and landscape descriptors for the iPhone 16 and iPhone 17 generations (10 devices, 20 entries): iPhone 16 393x852 scale 3 iPhone 16 Plus 430x932 scale 3 iPhone 16 Pro 402x874 scale 3 iPhone 16 Pro Max 440x956 scale 3 iPhone 16e 390x844 scale 3 iPhone 17 402x874 scale 3 iPhone Air 420x912 scale 3 iPhone 17 Pro 402x874 scale 3 iPhone 17 Pro Max 440x956 scale 3 iPhone 17e 390x844 scale 3 Screen and scale values are taken from ios-resolution.com. Browser-chrome subtraction follows the existing iPhone 15 entries in this file (193 px portrait / 118 + 50 px landscape). UA string mirrors the existing iPhone 15 entries: Mozilla/5.0 (iPhone; CPU iPhone OS 18_7 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/26.4 Mobile/15E148 Safari/604.1 "iPhone OS 18_7" reflects Apple's UA OS-version freeze introduced in iOS 26: https://www.kochava.com/blog/ios-26-apple-freezes-os-version/ The Version/26.4 segment will be auto-normalised by doclint to whatever WebKit version Playwright currently bundles.
cc82c5a to
af8115b
Compare
Summary
Add device descriptors for the iPhone 16 and iPhone 17 generations to
deviceDescriptorsSource.json. Every device has portrait and landscape variants, following the conventions of existing iPhone entries in this file. Pre-existing entries are unchanged.Originally this branch also added Pixel 9 / 10 family entries, but #40928 landed first and covers the same range; rebased to iPhone-only to avoid duplication.
Devices added
10 devices (20 entries with landscape), all
defaultBrowserType: webkit:Browser-chrome subtraction for the viewport values follows the existing iPhone 15 entries: 193 px portrait / 118 + 50 px landscape.
User-Agent string
All entries use the real-device UA captured from an iPhone 17 Pro:
iPhone OS 18_7reflects Apple's UA OS-version freeze introduced in iOS 26 — Safari on any iOS 26+ iPhone now reports18_7regardless of the underlying OS version. Ref: https://www.kochava.com/blog/ios-26-apple-freezes-os-version/Source