fix: improve error handling for ariaSnapshot and fixture integrity#41502
Open
faisalaffan wants to merge 2 commits into
Open
fix: improve error handling for ariaSnapshot and fixture integrity#41502faisalaffan wants to merge 2 commits into
faisalaffan wants to merge 2 commits into
Conversation
Member
|
Please start with filing an issue. |
Member
|
@faisalaffan can you address the comment and rebase so that we could merge it? |
faisalaffan
force-pushed
the
fix-error-handling
branch
from
bf8acc5 to
4bf5eeb
Compare
Author
|
@yury-s already rebased and dropped the fixtureRunner change, only the ariaSnapshot debugLogger fix remains. Ready for another look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small error-handling improvements:
catch {}withdebugLogger.log(...)so AI snapshot failures during test errors are traceableconsole.error+ silent_usages.clear()withthrow new Error(...)— fixture integrity violations now fail fast instead of silently corrupting state