fix(reporter): expose setup/teardown projects to preprocessSuite#41731
Open
Skn0tt wants to merge 2 commits into
Open
fix(reporter): expose setup/teardown projects to preprocessSuite#41731Skn0tt wants to merge 2 commits into
Skn0tt wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Dropped the reverse() so setup/teardown projects keep the same order in the root suite as before, avoiding a spurious UI mode filter reorder.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"5 failed 7755 passed, 1249 skipped Merge workflow run. |
Contributor
Test results for "tests 1"3 flaky49521 passed, 1161 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preprocessSuite()only exposed the top-level project suites, so a shard-balancing reporter couldn't measure the tests inside setup/teardown projects and weigh them.This moves the dependency projects into the root suite before
preprocessSuiteruns, so reporters can see them. They're read-only -skip()/fixme()/fail()/exclude()throw on a dependency test or suite, since these always run in full. Identify them viatestProject.dependenciesandtestProject.teardown.Sharding is unchanged: still splits only the top-level projects, keeps every dependency test.
Closes #41708