fix(test-runner): run project teardown after max-failures stop#41735
Closed
pradapjackie wants to merge 2 commits into
Closed
fix(test-runner): run project teardown after max-failures stop#41735pradapjackie wants to merge 2 commits into
pradapjackie wants to merge 2 commits into
Conversation
When --max-failures stops the suite, still schedule teardown projects so cleanup is not skipped. Fixes microsoft#41713.
Do not mark teardown tests as interrupted after max-failures has already stopped the suite.
Member
|
Thanks @pradapjackie — closing in favor of #41737. Max-failures touches the dispatcher/phase-scheduling core, so we want to keep iterating on it in-team and get the edge cases right (e.g. teardown sharing a phase with a regular project). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41713.
Summary
--max-failuresstops the suite, still schedule project teardown projectsignoreMaxFailuresso teardown phases are not stopped by the max-failures gate--max-failures=1Motivation
Project teardowns are often used for cleanup (DB, cloud resources). Skipping them when max-failures is hit can leave environments dirty.
Test plan
npm run ttest -- tests/playwright-test/max-failures.spec.tsnpm run ttest -- tests/playwright-test/deps.spec.ts -g teardown