Skip to content

Revert "feat(evaluate): allow passing functions as evaluate arguments (#41801)"#41881

Closed
pavelfeldman wants to merge 2 commits into
microsoft:mainfrom
pavelfeldman:revert-eval-exp
Closed

Revert "feat(evaluate): allow passing functions as evaluate arguments (#41801)"#41881
pavelfeldman wants to merge 2 commits into
microsoft:mainfrom
pavelfeldman:revert-eval-exp

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed @mcp-macos-latest-chrome

7759 passed, 1249 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:282 › should click `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:371 › should produce network events, routing, and annotations for Service Worker `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node20`

49802 passed, 1188 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🟢 The one failure is a pre-existing flake — the PR is clear

[chrome] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed fails on main and many unrelated PRs, and this revert doesn't touch the MCP annotate flow.

Details

Only one real failure in the report; everything else passed. This PR reverts the "functions as evaluate arguments" feature — it touches evaluate serialization (utilityScriptSerializers, bindingsController, page evaluate, ct-core serializers). None of that is on the MCP screenshot/annotate code path.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants