test: fixme WebSocket locale test in Chromium 150#41944
Merged
Conversation
`browsercontext-locale.spec.ts › should send Accept-Language header on
WebSocket handshake` fails 100% on the branded Google Chrome and Microsoft
Edge channels while passing on Chromium. Branded builds send the browser's
own `Accept-Language` (`en-US,en;q=0.9`) on the WebSocket handshake instead
of the emulated `en-GB` locale, so the assertion always fails. Scope a
`fixme` to those channels, mirroring the existing Firefox `fixme`.
DB evidence (rolling window, expected_status=passed): 100% fail on every
branded bot that runs it, still failing through Jul 22 —
chrome-ubuntu-22.04 88/88, msedge-windows-latest 88/88, chrome-macos-latest
88/88, chrome-windows-latest 88/88. 0 failures on any chromium-* bot.
Error: expect(...).toContain('en-GB'); received 'en-US,en;q=0.9' (x352).
Test added Jul 21 in #41904; related issue
#23732.
Emoji run history — msedge-windows-latest (22 runs, oldest first):
[🟥](https://github.com/microsoft/playwright/actions/runs/29856729151/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29859883032/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29865460136/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29866867131/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29867308985/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29873996100/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29874748609/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29874783963/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29877078341/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29879172510/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29904950059/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29915407358/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29918102409/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29924682554/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29931173316/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29932910968/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29933325202/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29938598979/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29940740538/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29945241493/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29957712363/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29960743816/attempts/1)
Verified locally on windows-latest with msedge installed:
- PWTEST_CHANNEL=msedge --project=chromium-library: reproduced the failure
(received 'en-US,en;q=0.9'), then confirmed skipped after the fixme.
- --project=chromium-library (no channel): still runs and passes.
- npm run flint clean (pre-existing unrelated html-reporter check-deps
failure reproduces without this change).
CI run: https://github.com/microsoft/playwright/actions/runs/29987350696
Suggested-reviewer: yury-s
Stable Chrome and Edge fail on Chromium 150, while Chrome Beta 151 and Edge Dev 152 pass. Gate on the affected version and teach the fix-flakes workflow to compare browser versions before channel names. Copilot-Session: 19d8bd17-13fd-482d-8228-94bd104679cf
Skn0tt
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"5 flaky50204 passed, 1190 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 7785 passed, 1262 skipped Merge workflow run. |
Skn0tt
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browsercontext-locale.spec.ts › should send Accept-Language header on WebSocket handshakefails in Chromium 150 branded builds, while newer branded versions pass:Chromium 150 sends the browser's
Accept-Language(en-US,en;q=0.9) on the WebSocket handshake instead of the emulateden-GBlocale. Scope thefixmeto that browser major so the test starts running again once stable rolls forward. This also teaches the fix-flakes agent to compare exact browser versions before using channel names in skip predicates.Test added Jul 21 in #41904; related issue #23732.
Emoji run history - Edge 150 on Windows, oldest first:
🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥
Verified locally on macOS with Chrome 150.0.7871.130:
PWTEST_CHANNEL=chromeskips the test.npm run flintpasses.Suggested-reviewer: yury-s