test: fixme Accept-Language override test on WebKit Windows#41977
Closed
microsoft-playwright-automation[bot] wants to merge 1 commit into
Closed
test: fixme Accept-Language override test on WebKit Windows#41977microsoft-playwright-automation[bot] wants to merge 1 commit into
microsoft-playwright-automation[bot] wants to merge 1 commit into
Conversation
`should send user Accept-Language header` is red on webkit-windows-latest only. WebKit on Windows appends the default language to a page-set `Accept-Language` header (got "de, en-US", expected "de"), so the fix in #41904 that stopped overriding page-set headers on macOS/Linux does not cover Windows. Scope a `fixme` to `webkit && isWindows`; the test still runs everywhere else. DB evidence (rolling window): webkit-windows-latest 45/46 runs failed (~98%), every other webkit bot (macOS, Ubuntu, xlarge, tracing) 0 failures; ongoing through 2026-07-24. Related issue: #23732 Linked run history (webkit-windows-latest, oldest first): [🟥](https://github.com/microsoft/playwright/actions/runs/29856729151/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29859883032/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29865460136/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29866867131/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29867308985/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29873996100/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29874748609/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29874783963/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29877078341/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29879172510/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29904950059/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29915407358/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29918102409/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29924682554/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29931173316/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29932910968/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29933325202/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29938598979/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29940740538/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29945241493/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29957712363/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29960743816/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/29986800439/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30000526442/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30002550609/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30003704436/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30012947805/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30013000317/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30013096187/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30016032633/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30019936660/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30020951577/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30028622968/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30030075729/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30034117131/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30037717793/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30043643329/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30046492986/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30046789125/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30047266180/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30054321343/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30055514373/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30056208622/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30059081941/attempts/1)[🟥](https://github.com/microsoft/playwright/actions/runs/30061239008/attempts/1)[🟩](https://github.com/microsoft/playwright/actions/runs/30064063966/attempts/1) Verified locally on windows-latest: `npm run wtest browsercontext-locale.spec.ts:192` reproduced the failure ("de, en-US"), then confirmed the test is skipped on webkit-windows and still runs+passes on chromium (`npm run ctest`). Fix-flakes run: https://github.com/microsoft/playwright/actions/runs/30074510511 Suggested-reviewer: yury-s
Member
|
It seems like #41975 doesn't have this one failing, but several other ones instead. Let's wait for WebKit rolls to fix this. |
Contributor
Test results for "MCP"7795 passed, 1266 skipped Merge workflow run. |
Contributor
Test results for "tests 1"5 flaky50322 passed, 1190 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should send user Accept-Language headeris red on webkit-windows-latest only.WebKit on Windows appends the default language to a page-set
Accept-Languageheader (got "de, en-US", expected "de"), so the fix in #41904 that stopped
overriding page-set headers on macOS/Linux does not cover Windows. Scope a
fixmetowebkit && isWindows; the test still runs everywhere else.DB evidence (rolling window): webkit-windows-latest 45/46 runs failed (~98%),
every other webkit bot (macOS, Ubuntu, xlarge, tracing) 0 failures; ongoing
through 2026-07-24. Related issue: #23732
Linked run history (webkit-windows-latest, oldest first):
🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟩
Verified locally on windows-latest:
npm run wtest browsercontext-locale.spec.ts:192reproduced the failure ("de, en-US"), then confirmed the test is skipped on
webkit-windows and still runs+passes on chromium (
npm run ctest).Fix-flakes run: https://github.com/microsoft/playwright/actions/runs/30074510511
Suggested-reviewer: yury-s