darker outline border on tab for sign in modal#11378
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Sign In modal styling in react-common to improve the visibility of keyboard focus indicators on identity provider buttons and the “Remember me” checkbox.
Changes:
- Override the focus outline styling for identity provider buttons when
:focus-visible. - Add a custom focus outline for the “Remember me” checkbox via
:focus-within.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/pxt-microbit#6824
And I also added similar styling for the remember me check box since that was very light as well
Before:
After:
