Scope toolboxes to editor to ensure unique ids#11382
Merged
Merged
Conversation
This is required to ensure that screen reader works with both the blocks and monaco toolboxes.
riknoll
requested changes
Jun 9, 2026
| import { classList } from "../../react-common/components/util" | ||
| import { Aria } from "react-modal" | ||
|
|
||
| type AriaHasPopup = boolean | "dialog" | "menu" | "false" | "listbox" | "grid" | "tree" | "true"; |
Member
There was a problem hiding this comment.
we should move this to some central location and update the typing you added in sui.tsx to reference it as well
Contributor
Author
There was a problem hiding this comment.
Turns out there is a built-in we can use instead, so have removed the custom type and used this in toolbox and sui.tsx 9ffc483
riknoll
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to ensure that screen reader works with both the blocks and monaco toolboxes.
This also improves semantics for the extensions tree item which tells users that it will open a dialog.