warn on function ref without invokation as statement#11386
Open
jwunderl wants to merge 5 commits into
Open
Conversation
srietkerk
approved these changes
Jun 10, 2026
srietkerk
left a comment
srietkerk
left a comment
Contributor
There was a problem hiding this comment.
Just some questions about the type of equality checks being done. Otherwise looks good.
jwunderl
commented
Jun 10, 2026
Co-authored-by: Sarah Rietkerk <49178322+srietkerk@users.noreply.github.com> Co-authored-by: Joey Wunderlich <jwunderl@users.noreply.github.com>
Member
Author
|
went ahead and did the 'ignore' button and ts-ignore handling |
… into dev/jwunderl/warnins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix microsoft/pxt-microbit#6912
not compile / simulator blocking, just renders as a warning
Gated the errors behind a compile flag that's only set on typecheck, since i know there are plenty of places like embed scenarios that check diags and may handle it as a proper error otherwise. Feels like there should be some other simple things we can use same flag for adding "probably wrong" warnings on. If it's anything mildly ambiguous would probably have to add an 'ignore' option with a button to fix (add tsignore like comment?) though