Improve screen reader output for show leds block#11391
Merged
Merged
Conversation
sourceBlock_.id clashed between the flyout and workspace copy of a block which caused screen reader bugs when trying to use ids derived from it to identify an active descendant.
riknoll
requested changes
Jun 10, 2026
| "aria-hidden": "true" | ||
| }); | ||
| } else { | ||
| cell.children[3]?.remove(); |
Member
There was a problem hiding this comment.
hmmm are we sure that subclasses of this matrix field will always have the same number of elements? might be better to tag this child with a data attribute and search for it instead of hardcoding an index
Contributor
Author
There was a problem hiding this comment.
We are not. This commit uses a data attribute to keep track of the two tone focus rect. It also fixes a bug where a two tone focus rect was removed when it was still wanted. 8aa194b
Fixes bug where two tone focus indicator was remove when it was still wanted.
riknoll
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
updateFocusIndicatormethod to ensure that the two tone focus indicator is updated when the LEDs are toggled on and off (unintentionally broken by https://github.com/microsoft/pxt/pull/11301/changes#diff-84524797c860e262a8416d54b981fa43859564638b17676b040481db4ee05b7dR150-R152)