Blockly v13.0.0-beta.9#11398
Open
microbit-matt-hillsdon wants to merge 2 commits into
Open
Conversation
Remove the workaround for keyboard disconnect on shadows now that's in Blockly proper. Various screen reader and keyboard navigation improvements. One important change is that the collapse icon on blocks is now reachable via the keyboard.
The custom expand icon's callback moved focus to the function collapse button, which only exists on function definitions. For other blocks focus was lost when the expand icon re-rendered away. Fall back to focusing the block itself. Rename maybeFocusMutatorButton to maybeMoveFocusFromButton now that it also focuses blocks and inputs, not just mutator buttons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo: https://blockly-v13-0-0-beta-9.review-pxt.pages.dev
I also opened microsoft/pxt-microbit#6923 in an attempt to do what was requested here microsoft/pxt-microbit#6919 (comment) but I don't fully understand the intended sequence. It seems to me that that change should be part of the PR that upgrades pxt in pxt-microbit and you can't merge it before that if you want CI to pass.