Skip to content

Proof of concept to use ariaLabels in Blockly dropdowns #11399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
microbit-robert wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Draft

Proof of concept to use ariaLabels in Blockly dropdowns #11399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions localtypings/pxtarget.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,7 @@ declare namespace ts.pxtc {
pySnippet?: string; // value used to generate python snippet

// On block
ariaLabel?: string;
subcategory?: string;
group?: string;
whenUsed?: boolean;
Expand Down
3 changes: 2 additions & 1 deletion pxtblocks/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,8 @@ function initBlock(block: Blockly.Block, info: pxtc.BlocksInfo, fn: pxtc.SymbolI
height: 36,
value: v.name
} : k,
v.namespace + "." + v.name
v.namespace + "." + v.name,
v.attributes.ariaLabel
];
});
// if a value is provided, move it first
Expand Down