-
Notifications
You must be signed in to change notification settings - Fork 211
Add loss policies to NoiseConfig to express different kinds of behavior on lost qubits
#3302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
orpuente-MS
wants to merge
12
commits into
main
Choose a base branch
from
oscarpuente/qubit-loss-policies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4213a95
add loss policies to `NoiseConfig` and support for it in all QIR simu…
orpuente-MS 021b21d
start NoisePolicy enum from 0
orpuente-MS 1af491a
fix test comment
orpuente-MS 941d453
reuse is_1q_op
orpuente-MS 8ee6259
noise policies only on multi-qubit gates + always apply idle noise on…
orpuente-MS 91350db
add warning when setting `.on_loss` on single-qubit gate
orpuente-MS 640f973
more reasonable swap behavior
orpuente-MS 885da6a
store policy in `policy` field instead of `q3`
orpuente-MS badd30c
Merge branch 'main' into oscarpuente/qubit-loss-policies
orpuente-MS ce23c8d
Merge branch 'main' into oscarpuente/qubit-loss-policies
orpuente-MS 6ef40fc
fix struct size calculation after merge
orpuente-MS 52a758b
fix flaky tests after merge
orpuente-MS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really 'ignore the loss'? I though this policy was specifically for SWAP, where its often just a relabelling of qubits. In that case, doesn't the loss get swapped as well? (i.e. if before the gate qubit A was lost and B was in state$\alpha$ , then after the swap A will be in state $\alpha$ and qubit B will be lost)